D26056: [dataengine/geolocation] Add logging category

2019-12-17 Thread Méven Car 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:523ef71c8790: [dataengine/geolocation] Add logging 
category (authored by meven).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26056?vs=71710=71711

REVISION DETAIL
  https://phabricator.kde.org/D26056

AFFECTED FILES
  dataengines/geolocation/CMakeLists.txt
  dataengines/geolocation/location_gps.cpp
  plasma-workspace.categories

To: meven, apol, #plasma, crossi, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26056: [dataengine/geolocation] Add logging category

2019-12-17 Thread Méven Car 
meven updated this revision to Diff 71710.
meven added a comment.


  Use qCDebug/qCWarning instead of qDebug/qWarning

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26056?vs=71704=71710

BRANCH
  arcpatch-D26056

REVISION DETAIL
  https://phabricator.kde.org/D26056

AFFECTED FILES
  dataengines/geolocation/CMakeLists.txt
  dataengines/geolocation/location_gps.cpp
  plasma-workspace.categories

To: meven, apol, #plasma, crossi, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26056: [dataengine/geolocation] Add logging category

2019-12-17 Thread Méven Car 
meven added inline comments.

INLINE COMMENTS

> location_gps.cpp:98
>  } else {
> -qDebug() << "gpsd not found";
> +qWarning(DATAENGINE_GEOLOCATION) << "gpsd not found";
>  }

Change to qCWarning

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D26056

REVISION DETAIL
  https://phabricator.kde.org/D26056

To: meven, apol, #plasma, crossi, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26056: [dataengine/geolocation] Add logging category

2019-12-16 Thread Méven Car 
meven updated this revision to Diff 71704.
meven added a comment.


  Add logging category

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26056?vs=71686=71704

BRANCH
  arcpatch-D26056

REVISION DETAIL
  https://phabricator.kde.org/D26056

AFFECTED FILES
  dataengines/geolocation/CMakeLists.txt
  dataengines/geolocation/location_gps.cpp
  plasma-workspace.categories

To: meven, apol, #plasma, crossi
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart