D26068: [KCM/Activity] Use KConfigXT to store settings

2019-12-30 Thread Méven Car 
meven added inline comments.

INLINE COMMENTS

> meven wrote in PrivacyTab.cpp:67
> That was not needed, will clean up

D26287 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26068

To: meven, #plasma, ervin, crossi
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26068: [KCM/Activity] Use KConfigXT to store settings

2019-12-30 Thread Méven Car 
meven added inline comments.

INLINE COMMENTS

> davidedmundson wrote in PrivacyTab.cpp:67
> Why do we explicitly call deleteLater on these?

That was not needed, will clean up

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26068

To: meven, #plasma, ervin, crossi
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26068: [KCM/Activity] Use KConfigXT to store settings

2019-12-30 Thread David Edmundson 
davidedmundson added inline comments.

INLINE COMMENTS

> PrivacyTab.cpp:67
> +{
> +mainConfig->deleteLater();
> +pluginConfig->deleteLater();

Why do we explicitly call deleteLater on these?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26068

To: meven, #plasma, ervin, crossi
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26068: [KCM/Activity] Use KConfigXT to store settings

2019-12-30 Thread Méven Car 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:df0a276b7eea: [KCM/Activity] Use KConfigXT to store 
settings (authored by meven).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26068?vs=72093=72369

REVISION DETAIL
  https://phabricator.kde.org/D26068

AFFECTED FILES
  kcms/activities/CMakeLists.txt
  kcms/activities/ExtraActivitiesInterface.cpp
  kcms/activities/PrivacyTab.cpp
  kcms/activities/SwitchingTab.cpp
  kcms/activities/kactivitymanagerd_plugins_settings.kcfg
  kcms/activities/kactivitymanagerd_plugins_settings.kcfgc
  kcms/activities/kactivitymanagerd_settings.kcfg
  kcms/activities/kactivitymanagerd_settings.kcfgc

To: meven, #plasma, ervin, crossi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26068: [KCM/Activity] Use KConfigXT to store settings

2019-12-23 Thread Méven Car 
meven updated this revision to Diff 72093.
meven marked 3 inline comments as done.
meven added a comment.


  Fix position of *

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26068?vs=72091=72093

BRANCH
  arcpatch-D26068

REVISION DETAIL
  https://phabricator.kde.org/D26068

AFFECTED FILES
  kcms/activities/CMakeLists.txt
  kcms/activities/ExtraActivitiesInterface.cpp
  kcms/activities/PrivacyTab.cpp
  kcms/activities/SwitchingTab.cpp
  kcms/activities/kactivitymanagerd_plugins_settings.kcfg
  kcms/activities/kactivitymanagerd_plugins_settings.kcfgc
  kcms/activities/kactivitymanagerd_settings.kcfg
  kcms/activities/kactivitymanagerd_settings.kcfgc

To: meven, #plasma, ervin, crossi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26068: [KCM/Activity] Use KConfigXT to store settings

2019-12-23 Thread Kevin Ottens 
ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> PrivacyTab.cpp:57
>  
> -Private()
> -: viewBlacklistedApplicationsRoot(nullptr)
> +Private(QObject* parent)
> +: mainConfig(new KActivityManagerdSettings(parent))

Space before * not after

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26068

To: meven, #plasma, ervin, crossi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26068: [KCM/Activity] Use KConfigXT to store settings

2019-12-23 Thread Méven Car 
meven updated this revision to Diff 72091.
meven added a comment.


  Fix * position

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26068?vs=72089=72091

BRANCH
  arcpatch-D26068

REVISION DETAIL
  https://phabricator.kde.org/D26068

AFFECTED FILES
  kcms/activities/CMakeLists.txt
  kcms/activities/ExtraActivitiesInterface.cpp
  kcms/activities/PrivacyTab.cpp
  kcms/activities/SwitchingTab.cpp
  kcms/activities/kactivitymanagerd_plugins_settings.kcfg
  kcms/activities/kactivitymanagerd_plugins_settings.kcfgc
  kcms/activities/kactivitymanagerd_settings.kcfg
  kcms/activities/kactivitymanagerd_settings.kcfgc

To: meven, #plasma, ervin, crossi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26068: [KCM/Activity] Use KConfigXT to store settings

2019-12-23 Thread Méven Car 
meven updated this revision to Diff 72089.
meven added a comment.


  Make pluginConfig and mainConfig pointers

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26068?vs=71729=72089

BRANCH
  arcpatch-D26068

REVISION DETAIL
  https://phabricator.kde.org/D26068

AFFECTED FILES
  kcms/activities/CMakeLists.txt
  kcms/activities/ExtraActivitiesInterface.cpp
  kcms/activities/PrivacyTab.cpp
  kcms/activities/SwitchingTab.cpp
  kcms/activities/kactivitymanagerd_plugins_settings.kcfg
  kcms/activities/kactivitymanagerd_plugins_settings.kcfgc
  kcms/activities/kactivitymanagerd_settings.kcfg
  kcms/activities/kactivitymanagerd_settings.kcfgc

To: meven, #plasma, ervin, crossi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26068: [KCM/Activity] Use KConfigXT to store settings

2019-12-23 Thread Kevin Ottens 
ervin requested changes to this revision.
ervin added a comment.
This revision now requires changes to proceed.


  Oops, selected wrong state :-)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26068

To: meven, #plasma, ervin, crossi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26068: [KCM/Activity] Use KConfigXT to store settings

2019-12-23 Thread Kevin Ottens 
ervin accepted this revision.
ervin added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> PrivacyTab.cpp:50
>  public:
> -KSharedConfig::Ptr mainConfig;
> -KSharedConfig::Ptr pluginConfig;
> +KActivityManagerdSettings mainConfig;
> +KActivityManagerdPluginsSettings pluginConfig;

I'd have it by pointer and give it a parent at construction time. It's a more 
common pattern for QObject as members.

> PrivacyTab.cpp:51
> +KActivityManagerdSettings mainConfig;
> +KActivityManagerdPluginsSettings pluginConfig;
>  

Ditto

REPOSITORY
  R119 Plasma Desktop

BRANCH
  activity_kcm

REVISION DETAIL
  https://phabricator.kde.org/D26068

To: meven, #plasma, ervin, crossi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26068: [KCM/Activity] Use KConfigXT to store settings

2019-12-17 Thread Méven Car 
meven updated this revision to Diff 71729.
meven added a comment.


  Ensure the black list opt-in checkbox change apply button state

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26068?vs=71728=71729

BRANCH
  activity_kcm

REVISION DETAIL
  https://phabricator.kde.org/D26068

AFFECTED FILES
  kcms/activities/CMakeLists.txt
  kcms/activities/ExtraActivitiesInterface.cpp
  kcms/activities/PrivacyTab.cpp
  kcms/activities/SwitchingTab.cpp
  kcms/activities/kactivitymanagerd_plugins_settings.kcfg
  kcms/activities/kactivitymanagerd_plugins_settings.kcfgc
  kcms/activities/kactivitymanagerd_settings.kcfg
  kcms/activities/kactivitymanagerd_settings.kcfgc

To: meven, #plasma, ervin, crossi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26068: [KCM/Activity] Use KConfigXT to store settings

2019-12-17 Thread Méven Car 
meven created this revision.
meven added reviewers: Plasma, ervin, crossi.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

TEST PLAN
  kcmshell5 kcm_activities
  Changed settings, restored defaults

REPOSITORY
  R119 Plasma Desktop

BRANCH
  activity_kcm

REVISION DETAIL
  https://phabricator.kde.org/D26068

AFFECTED FILES
  kcms/activities/CMakeLists.txt
  kcms/activities/ExtraActivitiesInterface.cpp
  kcms/activities/PrivacyTab.cpp
  kcms/activities/SwitchingTab.cpp
  kcms/activities/kactivitymanagerd_plugins_settings.kcfg
  kcms/activities/kactivitymanagerd_plugins_settings.kcfgc
  kcms/activities/kactivitymanagerd_settings.kcfg
  kcms/activities/kactivitymanagerd_settings.kcfgc

To: meven, #plasma, ervin, crossi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart