D26111: KRunner add a recentlyused runner accessing KActivityStats data

meven planned changes to this revision. meven added a comment. In D26111#589209 , @ivan wrote: > > Why not change the recentdocuments runner? > > Will do REPOSITORY R120 Plasma Workspace REVISION DETAIL

D26111: KRunner add a recentlyused runner accessing KActivityStats data

ivan added a comment. > Why not change the recentdocuments runner? Looks fine to me, I just don't see a response to this comment. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26111 To: meven, #plasma, ivan, ngraham, broulik Cc: broulik,

D26111: KRunner add a recentlyused runner accessing KActivityStats data

meven added a comment. Anyone to review this ? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26111 To: meven, #plasma, ivan, ngraham, broulik Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot,

D26111: KRunner add a recentlyused runner accessing KActivityStats data

meven marked 3 inline comments as done. meven added a comment. In D26111#580344 , @meven wrote: > Two points raised by @broulik but not resolved : > > - should display a specific icon based on file mimetype ? > - should we allow to open a

D26111: KRunner add a recentlyused runner accessing KActivityStats data

meven updated this revision to Diff 71865. meven added a comment. Better Name in json REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26111?vs=71858=71865 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26111 AFFECTED FILES

D26111: KRunner add a recentlyused runner accessing KActivityStats data

meven added a comment. Two points raised by @broulik but not resolved : - should display a specific icon based on file mimetype ? - should we allow to open a folder's parent folder through an action I am in favor of keeping those two behaviors, but I would welcome other

D26111: KRunner add a recentlyused runner accessing KActivityStats data

meven updated this revision to Diff 71858. meven marked 5 inline comments as done. meven added a comment. address review REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26111?vs=71857=71858 BRANCH master REVISION DETAIL

D26111: KRunner add a recentlyused runner accessing KActivityStats data

broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. Why not change the recentdocuments runner? We have various places where we whitelist recentdocuments as a runner and if a user disabled it, this would not be carried over

D26111: KRunner add a recentlyused runner accessing KActivityStats data

meven added a comment. I am planning to remove recentdocument later. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26111 To: meven, #plasma, ivan, ngraham Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen,

D26111: KRunner add a recentlyused runner accessing KActivityStats data

meven created this revision. meven added reviewers: Plasma, ivan, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY It is much more versatile over the current recentdocument runner : - It is activity