D26418: [Applet]Add global mute function

This revision was automatically updated to reflect the committed changes. Closed by commit R115:681e1c8faaaf: [Applet]Add global mute function (authored by gvgeo, committed by ngraham). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D26418: [Applet]Add global mute function

gvgeo updated this revision to Diff 74149. gvgeo added a comment. Last update by accident... REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26418?vs=74148=74149 BRANCH mute2 (branched from master) REVISION DETAIL

D26418: [Applet]Add global mute function

gvgeo updated this revision to Diff 74148. gvgeo added a comment. rebase REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26418?vs=74147=74148 BRANCH menu3 (branched from master) REVISION DETAIL https://phabricator.kde.org/D26418

D26418: [Applet]Add global mute function

gvgeo updated this revision to Diff 74147. gvgeo added a comment. rebase REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26418?vs=73921=74147 BRANCH mute2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D26418

D26418: [Applet]Add global mute function

gvgeo updated this revision to Diff 73921. gvgeo added a comment. Rebase REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26418?vs=73240=73921 BRANCH mute2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D26418

D26418: [Applet]Add global mute function

gvgeo updated this revision to Diff 73240. gvgeo added a comment. Removal of trailing space REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26418?vs=72916=73240 BRANCH mute (branched from master) REVISION DETAIL

D26418: [Applet]Add global mute function

gvgeo updated this revision to Diff 72916. gvgeo added a comment. rebase REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26418?vs=72857=72916 BRANCH mute (branched from master) REVISION DETAIL https://phabricator.kde.org/D26418

D26418: [Applet]Add global mute function

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Much better, thanks. REPOSITORY R115 Plasma Audio Volume Applet BRANCH mute (branched from master) REVISION DETAIL https://phabricator.kde.org/D26418 To: gvgeo, #vdg, #plasma,

D26418: [Applet]Add global mute function

gvgeo updated this revision to Diff 72857. gvgeo added a comment. Cleanup Planed changes REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26418?vs=72762=72857 BRANCH mute (branched from master) REVISION DETAIL

D26418: [Applet]Add global mute function

gvgeo planned changes to this revision. gvgeo added a comment. Will remove timer,`onRowsInserted` in `paSinkModel` does the same during init. And will move `forceGlobalMute` inside `paSinkModel`. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL

D26418: [Applet]Add global mute function

ngraham added a comment. Code looks sane enough except for one thing: INLINE COMMENTS > main.qml:659 > > +// Wait for paSinkModel init. > +Timer { This makes me nervous. How do we know it will have initialized after 200 ms? Is there an `onFinished` signal we can listen for or

D26418: [Applet]Add global mute function

ngraham accepted this revision as: VDG. ngraham added a comment. UI and functionality are good. I'll leave the code review to a #plasma person or @drosca. There is quite a lot of added code. REPOSITORY R115 Plasma Audio Volume Applet REVISION

D26418: [Applet]Add global mute function

gvgeo updated this revision to Diff 72762. gvgeo added a comment. Add global mute for shortcuts/tray icon. Will prioritize current sink mute state, and accordingly will also trigger global mute. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D26418: [Applet]Add global mute function

ngraham added a comment. Current icon is fine BTW. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D26418 To: gvgeo, #vdg, #plasma, drosca Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen,

D26418: [Applet]Add global mute function

ngraham added a comment. Nice. One thing I notice is that when I press the mute button on my keyboard, it triggers the applet to enter the muted state for the (sole) audio output, but it does not trigger the new global muted state. Could it do this? REPOSITORY R115 Plasma Audio Volume

D26418: [Applet]Add global mute function

gvgeo updated this revision to Diff 72753. gvgeo added a comment. squash REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26418?vs=72741=72753 BRANCH mute (branched from master) REVISION DETAIL https://phabricator.kde.org/D26418

D26418: [Applet]Add global mute function

gvgeo added a comment. Icon is not monochrome. Is there an alternative? Or have to do it with desaturate graphical effect? With the current functionality, fits nice to make it colored when all the devices are muted. This adds a semi enabled state, when global mute is not enabled.

D26418: [APPLET]Add global mute function

gvgeo created this revision. gvgeo added reviewers: VDG, Plasma, drosca. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Add a Mute icon that will force all playback devices to mute. Even if new device/port