D26421: Only show full name in review dialog

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:ec5464e70642: Only show full name in review dialog 
(authored by ngraham).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26421?vs=72767=73582

REVISION DETAIL
  https://phabricator.kde.org/D26421

AFFECTED FILES
  libdiscover/appstream/OdrsReviewsBackend.cpp

To: ngraham, #discover_software_store, apol
Cc: jgrulich, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26421: Only show full name in review dialog

[Nathaniel Graham]

ngraham added a comment.


  Thanks!

REPOSITORY
  R134 Discover Software Store

BRANCH
  full-name-only (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26421

To: ngraham, #discover_software_store, apol
Cc: jgrulich, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26421: Only show full name in review dialog

[Nathaniel Graham]

ngraham added a comment.


  @apol ping.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D26421

To: ngraham, #discover_software_store, apol
Cc: jgrulich, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26421: Only show full name in review dialog

[Jan Grulich]

jgrulich added a comment.


  I don't really remember, but I can see in the userHash() it's not used so 
this is probably safe. In the userHash() we directly use KUser().

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D26421

To: ngraham, #discover_software_store, apol
Cc: jgrulich, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26421: Only show full name in review dialog

[Aleix Pol Gonzalez]

apol added a subscriber: jgrulich.
apol added a comment.


  @jgrulich you included that, right? Do you remember why? I can see it's used 
for generating the user hash.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D26421

To: ngraham, #discover_software_store, apol
Cc: jgrulich, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26421: Only show full name in review dialog

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Discover Software Store, apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  The review gets submitted with your full name, but the review dialog 
currently shows
  both the full name and username. This patch removes the username display so 
that it shows
  the actual name string that will be used.

TEST PLAN
  Before: F7860875: Before.png 
  After: F7860874: After.png 

REPOSITORY
  R134 Discover Software Store

BRANCH
  full-name-only (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26421

AFFECTED FILES
  libdiscover/appstream/OdrsReviewsBackend.cpp

To: ngraham, #discover_software_store, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart