This revision was automatically updated to reflect the committed changes.
Closed by commit R119:aa2119a835e9: [KDED KCM] Rewrite as KDeclarative
ScrollViewKCM (authored by broulik).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D26506?vs=73369=73705#toc
REPOSITORY
R119 Plasma Desktop
ngraham accepted this revision.
ngraham added a comment.
Lovely.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D26506
To: broulik, #plasma, #vdg, mart, ngraham
Cc: mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,
fbampaloukas,
broulik updated this revision to Diff 73369.
broulik edited the summary of this revision.
broulik edited the test plan for this revision.
broulik added a comment.
- Remove enable/disable animation
- Enabled becomes green
- Now monitors kded running
- Notifies when modules got
mart accepted this revision as: mart.
mart added a comment.
This revision is now accepted and ready to land.
Code wise is ok
I think the checkbox for exabling/disabling the service is fine usability wise
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
broulik updated this revision to Diff 73089.
broulik added a comment.
- Filter duplicates
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26506?vs=73085=73089
REVISION DETAIL
https://phabricator.kde.org/D26506
AFFECTED FILES
CMakeLists.txt
ngraham added a comment.
Thanks, much better, now I can test it out.
Some initial thoughts:
- Overall very nice! I like it.
- Making the "Running" and "Not Running" labels colorize themselves and then
transition to the normal color when toggles is flashy and cool, but I wonder if
broulik updated this revision to Diff 73085.
broulik added a comment.
- Minor fixes
- Fix Cmake
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26506?vs=73017=73085
REVISION DETAIL
https://phabricator.kde.org/D26506
AFFECTED FILES
ngraham added a comment.
Nice! It seems to have a CMake error though:
CMake Error at kcms/kded/CMakeLists.txt:10 (qt5_add_dbus_interface):
qt5_add_dbus_interface Function invoked with incorrect arguments for
function named: QT5_ADD_DBUS_INTERFACE
REPOSITORY
R119 Plasma
broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
This rewrites the "Background services" KCM in QML using `ScrollViewKCM`.
The two separate
