D26531: [Wallpaper] Show author as subtitle in configuration

2020-01-21 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:3729873fdd1d: [Wallpaper] Show author as subtitle in 
configuration (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26531?vs=73094=74018

REVISION DETAIL
  https://phabricator.kde.org/D26531

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml

To: broulik, #plasma, #vdg, ngraham
Cc: mart, filipf, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D26531: [Wallpaper] Show author as subtitle in configuration

2020-01-13 Thread Nathaniel Graham 
ngraham added a comment.


  Submitted a patch to fix it: D26634 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26531

To: broulik, #plasma, #vdg
Cc: mart, filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D26531: [Wallpaper] Show author as subtitle in configuration

2020-01-13 Thread Nathaniel Graham 
ngraham added a comment.


  I'll look into it, yeah.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26531

To: broulik, #plasma, #vdg
Cc: mart, filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D26531: [Wallpaper] Show author as subtitle in configuration

2020-01-13 Thread Marco Martin 
mart added a comment.


  In D26531#592814 , @broulik wrote:
  
  > > can you look into that?
  >
  > Perhaps @ngraham can. In any case, if this were fixed, it would not make it 
for 5.18.
  
  
  no biggie. let's put it in as soon as the new cycle starts

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26531

To: broulik, #plasma, #vdg
Cc: mart, filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D26531: [Wallpaper] Show author as subtitle in configuration

2020-01-12 Thread Kai Uwe Broulik 
broulik added a comment.


  > can you look into that?
  
  Perhaps @ngraham can.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26531

To: broulik, #plasma, #vdg
Cc: mart, filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D26531: [Wallpaper] Show author as subtitle in configuration

2020-01-10 Thread Marco Martin 
mart added a comment.


  In D26531#590729 , @broulik wrote:
  
  > > However I see a problem with the delegate cell size:
  >
  > That's unrelated and something I would have expected was tested when this 
feature was added.
  
  
  can you look into that?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26531

To: broulik, #plasma, #vdg
Cc: mart, filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D26531: [Wallpaper] Show author as subtitle in configuration

2020-01-09 Thread Kai Uwe Broulik 
broulik added a comment.


  > "By" can also be tricky to translate into other languages
  
  That's why we have context. Currently it also has " by " 
explanation.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26531

To: broulik, #plasma, #vdg
Cc: filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26531: [Wallpaper] Show author as subtitle in configuration

2020-01-09 Thread Kai Uwe Broulik 
broulik added a comment.


  > However I see a problem with the delegate cell size:
  
  That's unrelated and something I would have expected was tested when this 
feature was added.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26531

To: broulik, #plasma, #vdg
Cc: filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26531: [Wallpaper] Show author as subtitle in configuration

2020-01-08 Thread Nathaniel Graham 
ngraham added a comment.


  All right, let's do this way then. However I see a problem with the delegate 
cell size: F7871404: Screenshot_20200108_154900.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26531

To: broulik, #plasma, #vdg
Cc: filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26531: [Wallpaper] Show author as subtitle in configuration

2020-01-08 Thread Filip Fila 
filipf added a comment.


  Good idea +1. I think an author's name is enough here since information is 
displayed in a similar way that songs info is ie. it should be obvious to 
everyone the second line lists the author.
  
  "By" can also be tricky to translate into other languages. In my language you 
can't just literally translate it because it would mean the wallpaper is made 
of the author's flesh. So instead of that the translator would have to add 
"Author: " everywhere or just omit it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26531

To: broulik, #plasma, #vdg
Cc: filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26531: [Wallpaper] Show author as subtitle in configuration

2020-01-08 Thread Nathaniel Graham 
ngraham added a comment.


  Might make sense to keep the "By" prefix, yeah. +1!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26531

To: broulik, #plasma, #vdg
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26531: [Wallpaper] Show author as subtitle in configuration

2020-01-08 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  If we have this feature now, let's use it and give the wallpaper authors the 
credit they deserve rather than being tucked away in the tooltip.

TEST PLAN
  F7871144: Screenshot_20200108_211105.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26531

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart