D26533: Add a logging category for the backend
This revision was automatically updated to reflect the committed changes. Closed by commit R134:160f10328366: Add a logging category for the backend (authored by meven). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26533?vs=73119&id=73121 REVISION DETAIL https://phabricator.kde.org/D26533 AFFECTED FILES discover.categories libdiscover/backends/PackageKitBackend/CMakeLists.txt libdiscover/backends/PackageKitBackend/LocalFilePKResource.cpp libdiscover/backends/PackageKitBackend/PKTransaction.cpp libdiscover/backends/PackageKitBackend/PackageKitBackend.cpp libdiscover/backends/PackageKitBackend/PackageKitNotifier.cpp libdiscover/backends/PackageKitBackend/PackageKitUpdater.cpp To: meven, apol, ngraham, mlaurent Cc: mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26533: Add a logging category for the backend
mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. Seems ok now for me :) thanks REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D26533 To: meven, apol, ngraham, mlaurent Cc: mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26533: Add a logging category for the backend
meven marked 2 inline comments as done. meven added inline comments. INLINE COMMENTS > mlaurent wrote in CMakeLists.txt:14 > Why adding it ? it's autogenerated so it's added by cmake directly The issue was that add_library takes directly a list of cpp directly, but ecm_qt_declare_logging_category needs a list of SRCS to append its generated cpp file. The cmake file was lacking _SRCS list variable in sum. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D26533 To: meven, apol, ngraham, mlaurent Cc: mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26533: Add a logging category for the backend
meven marked an inline comment as done. meven added a comment. ping @mlaurent REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D26533 To: meven, apol, ngraham, mlaurent Cc: mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26533: Add a logging category for the backend
meven updated this revision to Diff 73119. meven added a comment. Fix CMake( add _SRCS vars) REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26533?vs=73096&id=73119 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26533 AFFECTED FILES discover.categories libdiscover/backends/PackageKitBackend/CMakeLists.txt libdiscover/backends/PackageKitBackend/LocalFilePKResource.cpp libdiscover/backends/PackageKitBackend/PKTransaction.cpp libdiscover/backends/PackageKitBackend/PackageKitBackend.cpp libdiscover/backends/PackageKitBackend/PackageKitNotifier.cpp libdiscover/backends/PackageKitBackend/PackageKitUpdater.cpp To: meven, apol, ngraham, mlaurent Cc: mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26533: Add a logging category for the backend
mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:14 > TransactionSet.cpp > +libdiscover_backend_debug.cpp > pkui.qrc Why adding it ? it's autogenerated so it's added by cmake directly > CMakeLists.txt:30 > +add_library(DiscoverPackageKitNotifier MODULE PackageKitNotifier.cpp > +libdiscover_backend_debug.cpp > +) Why you add this file too ? it's autogenerated by ecm_qt_declare_logging_category and added directly REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D26533 To: meven, apol, ngraham, mlaurent Cc: mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26533: Add a logging category for the backend
meven created this revision. meven added reviewers: apol, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY To get rid of tons of logs like : using... PackageKit::Transaction(0x55db7f249ab0) "/14940_dbaecdcb" using... PackageKit::Transaction(0x55db7f33fba0) "/14940_dbaecdcb" using... PackageKit::Transaction(0x55db7d97b860) "/14941_ecaeeebe" TEST PLAN builds REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D26533 AFFECTED FILES discover.categories libdiscover/backends/PackageKitBackend/CMakeLists.txt libdiscover/backends/PackageKitBackend/LocalFilePKResource.cpp libdiscover/backends/PackageKitBackend/PKTransaction.cpp libdiscover/backends/PackageKitBackend/PackageKitBackend.cpp libdiscover/backends/PackageKitBackend/PackageKitNotifier.cpp libdiscover/backends/PackageKitBackend/PackageKitUpdater.cpp To: meven, apol, ngraham Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
