D26547: pk: Load the AppStream database on a separate thread

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R134:2ce5eb9dab5b: pk: Load the AppStream database on a separate thread (authored by apol). CHANGED PRIOR TO COMMIT

D26547: pk: Load the AppStream database on a separate thread

apol marked 2 inline comments as done. apol added inline comments. INLINE COMMENTS > broulik wrote in PackageKitBackend.cpp:502 > Why is this delayed now? It's a quirk of how ResultsStream works. We need the results to be emitted when something is listening to it. If you look at it closely, it

D26547: pk: Load the AppStream database on a separate thread

apol updated this revision to Diff 73173. apol marked an inline comment as done. apol added a comment. kai comments REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26547?vs=73139=73173 BRANCH arcpatch-D26547 REVISION DETAIL

D26547: pk: Load the AppStream database on a separate thread

broulik added inline comments. INLINE COMMENTS > PackageKitBackend.cpp:198 > } > +} else > +ret.components << component; Coding style .. > PackageKitBackend.cpp:502 > +} else { > +QTimer::singleShot(0, this, f); > +} Why is this

D26547: pk: Load the AppStream database on a separate thread

apol added a comment. In D26547#590948 , @ngraham wrote: > Very nice. Launching definitely feels faster now. This also fixes https://bugs.kde.org/show_bug.cgi?id=409262 for me. Does that make any sense? Yes, it makes sense. > One

D26547: pk: Load the AppStream database on a separate thread

ngraham added a comment. Very nice. Launching definitely feels faster now. This also fixes https://bugs.kde.org/show_bug.cgi?id=409262 for me. Does that make any sense? One thing I notice is that the increased speed results in the "you're not connected to a network" message erroneously

D26547: pk: Load the AppStream database on a separate thread

apol created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY No need to block the backends load on PackageKit appstream usage. BUG: 409599 TEST PLAN Tested manually REPOSITORY R134