D26565: KCM/Component Revamp email config

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d1f62c16c878: KCM/Component Revamp email config (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26565?vs=73957=73959 REVISION DETAIL

D26565: KCM/Component Revamp email config

meven updated this revision to Diff 73957. meven added a comment. Avoid indentation level REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26565?vs=73948=73957 BRANCH email-config REVISION DETAIL https://phabricator.kde.org/D26565 AFFECTED

D26565: KCM/Component Revamp email config

ervin accepted this revision. ervin added inline comments. INLINE COMMENTS > componentchooseremail.cpp:109 > +} > +if (service) { > +// avoid duplicates entry when email clients are present in > mimeapps.list's Added Associations too I really meant if (!service) +

D26565: KCM/Component Revamp email config

meven updated this revision to Diff 73948. meven marked 2 inline comments as done. meven added a comment. Move static variable to a proper namespace block, refactor some code for clarity, fix selecting a newly selected email client REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26565: KCM/Component Revamp email config

ervin added inline comments. INLINE COMMENTS > componentchooseremail.cpp:67 > } > +static const char s_AddedAssociations[] = "Added Associations"; > +static const auto s_mimetype = QStringLiteral("x-scheme-handler/mailto"); Not a huge fan of static consts appearing like this in the middle of

D26565: KCM/Component Revamp email config

meven updated this revision to Diff 73747. meven marked an inline comment as done. meven added a comment. Remove a bad line REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26565?vs=73695=73747 BRANCH email-config REVISION DETAIL

D26565: KCM/Component Revamp email config

meven added inline comments. INLINE COMMENTS > componentchooseremail.cpp:144 > +// select newly inserted email client > +m_currentIndex = emailClientsCombo->count() - 2; > +emailClientsCombo->setCurrentIndex(m_currentIndex); remove REPOSITORY R119 Plasma

D26565: KCM/Component Revamp email config

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I'm so sorry, this was my mistake. Somehow KMail got re-installed without my knowledge. Probably https://bugzilla.suse.com/show_bug.cgi?id=1035802 biting me again. Once I've removed

D26565: KCM/Component Revamp email config

meven added a comment. In D26565#595522 , @ngraham wrote: > Hmm, I don't have KMail installed yet it shows up in the combobox anyway. I don't think that makes sense. Everything in the combobox comes from /usr/share/applications/*desktop

D26565: KCM/Component Revamp email config

ngraham added a comment. Hmm, I don't have KMail installed yet it shows up in the combobox anyway. I don't think that makes sense. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26565 To: meven, ngraham, ervin, #plasma, bport, crossi, dvratil Cc:

D26565: KCM/Component Revamp email config

meven updated this revision to Diff 73695. meven added a comment. Add a couple of const REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26565?vs=73548=73695 BRANCH email-config REVISION DETAIL https://phabricator.kde.org/D26565 AFFECTED FILES

D26565: KCM/Component Revamp email config

meven added a comment. In D26565#594353 , @ngraham wrote: > Let me know if and when this is reviewable, or if it's still WIP. This is good for review. I am now working towards preventing a potential issue : If a user set say

D26565: KCM/Component Revamp email config

ngraham added a comment. Let me know if and when this is reviewable, or if it's still WIP. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26565 To: meven, ngraham, ervin, #plasma, bport, crossi Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D26565: KCM/Component Revamp email config

meven updated this revision to Diff 73548. meven added a comment. clean some unused incudes REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26565?vs=73547=73548 BRANCH email-config REVISION DETAIL https://phabricator.kde.org/D26565 AFFECTED

D26565: KCM/Component Revamp email config

meven updated this revision to Diff 73547. meven added a comment. Allow to select any app as email client, mimeapps.list preferred email is the source of truth regarding default mail client, depends on KF5.67 (post plasma 5.18) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26565: KCM/Component Revamp email config

ngraham added a comment. In D26565#592891 , @meven wrote: > It means we will need to write .desktop file on the fly which KOpenWithDialog can do. > Do we want the previously entered commands to appear in the list ? I think so. We

D26565: KCM/Component Revamp email config

meven added a comment. In D26565#591581 , @ngraham wrote: > In D26565#591542 , @meven wrote: > > > Do you mean, we should drop command line text fields, like we have in the terminal and browser

D26565: KCM/Component Revamp email config

meven updated this revision to Diff 73375. meven added a comment. Clean reference to unused and not existant .config/emails directory REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26565?vs=73212=73375 BRANCH email-config REVISION DETAIL

D26565: KCM/Component Revamp email config

ngraham added a comment. In D26565#591542 , @meven wrote: > Do you mean, we should drop command line text fields, like we have in the terminal and browser section ? Only comboxbox ? We don't want to lose this feature, but the text field

D26565: KCM/Component Revamp email config

meven added a comment. In D26565#591535 , @ngraham wrote: > Very nice, I think this is the way to go, not only for this component but for the others too. We should drop the group box too because with only one item, there's no longer anything to

D26565: KCM/Component Revamp email config

ngraham added a comment. Very nice, I think this is the way to go, not only for this component but for the others too. We should drop the group box too because with only one item, there's no longer anything to group! :) We can just switch it out for a label to the left of the combobox.

D26565: KCM/Component Revamp email config

meven updated this revision to Diff 73212. meven added a comment. minor change REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26565?vs=73211=73212 BRANCH email-config REVISION DETAIL https://phabricator.kde.org/D26565 AFFECTED FILES

D26565: KCM/Component Revamp email config

meven created this revision. meven added reviewers: ngraham, ervin, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Simplify UI: - Select option in the available email clients REPOSITORY R119