D26570: Improve Plasma user feedback introspection

This revision was automatically updated to reflect the committed changes. Closed by commit R120:35dcbd3dd89c: Improve Plasma user feedback introspection (authored by apol). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26570?vs=73641=73674 REVISION

D26570: Improve Plasma user feedback introspection

ngraham added a comment. Very nice. It occurs to me that by showing the full list of what gets sent, we no longer need to show the details text. It's rendered obsolete by showing the actual list of what gets sent. Can we remove the description from the KCM here without touching

D26570: Improve Plasma user feedback introspection

apol added inline comments. INLINE COMMENTS > davidedmundson wrote in feedback.cpp:41 > where do you use this? It's used by `std::sort(m_feedbackSources.begin(), m_feedbackSources.end()...` > davidedmundson wrote in feedback.cpp:109 > This doesn't look right. > > With 2 async processes, the

D26570: Improve Plasma user feedback introspection

davidedmundson added a comment. Quite a clever solution. I like the general idea. One major comment at the bottom, rest aren't important. INLINE COMMENTS > feedback.cpp:41 > + > +inline void swap(QJsonValueRef v1, QJsonValueRef v2) > +{ where do you use this? > feedback.cpp:109 > +

D26570: Improve Plasma user feedback introspection

apol updated this revision to Diff 73641. apol added a comment. rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26570?vs=73315=73641 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26570 AFFECTED FILES

D26570: Improve Plasma user feedback introspection

apol updated this revision to Diff 73315. apol added a comment. Async load REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26570?vs=73227=73315 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26570 AFFECTED FILES

D26570: Improve Plasma user feedback introspection

apol added a comment. F7876596: photo_2020-01-10_20-09-45.jpg REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26570 To: apol, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas,

D26570: Improve Plasma user feedback introspection

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Before loading the view, query all plasma processes and show why they're using KUserFeedback.