D26621: [kstyle] Drop Qt 4 style plugin
This revision was automatically updated to reflect the committed changes. Closed by commit R113:94c856314c16: [kstyle] Drop Qt 4 style plugin (authored by zzag). REPOSITORY R113 Oxygen Theme CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26621?vs=73391=74065 REVISION DETAIL https://phabricator.kde.org/D26621 AFFECTED FILES CMakeLists.txt kstyle/CMakeLists.txt kstyle/config/CMakeLists.txt kstyle/config/oxygenstyleconfig.cpp kstyle/demo/CMakeLists.txt kstyle/demo/main.cpp kstyle/demo/oxygendemodialog.cpp kstyle/demo/oxygenframedemowidget.cpp kstyle/kstylekde4compat.cpp kstyle/kstylekde4compat.h kstyle/oxygen.h kstyle/oxygenmnemonics.cpp kstyle/oxygenshadowhelper.cpp kstyle/oxygenstyle.cpp kstyle/oxygenstyle.h kstyle/oxygenstylehelper.cpp kstyle/oxygenstylehelper.h kstyle/oxygenstyleplugin.cpp kstyle/oxygenstyleplugin.h kstyle/oxygenwindowmanager.cpp kstyle/oxygenwindowmanager.h kstyle/transitions/oxygentransitionwidget.cpp liboxygen/CMakeLists.txt liboxygen/config-liboxygen.h.cmake liboxygen/liboxygen.h liboxygen/oxygenhelper.cpp liboxygen/oxygenhelper.h liboxygen/oxygenshadowcache.cpp liboxygen/oxygenshadowconfigwidget.cpp liboxygen/oxygentileset.cpp To: zzag, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26621: [kstyle] Drop Qt 4 style plugin
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Seems we got the go-ahead from kde-distro-packagers ML so ++ After 5.18 forks please REPOSITORY R113 Oxygen Theme BRANCH port-to-shadows-api REVISION DETAIL https://phabricator.kde.org/D26621 To: zzag, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26621: [kstyle] Drop Qt 4 style plugin
zzag created this revision. zzag added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY KWindowSystem cannot be used in the Qt 4 style plugin. On the other hand, we need to use KWindowSystem to make QWidget-based internal clients in KWin cast drop-shadows. Another problem with the Qt 4 style plugin is that some distributions have already dropped Qt 4 (it's been EOL for almost 5 years), so one has to build it yourself in order to verify that his or her change works with Qt 4. Given maintenance burden and the fact that Qt 6 is around the corner, this change drops the Qt 4 style plugin. REPOSITORY R113 Oxygen Theme BRANCH port-to-shadows-api REVISION DETAIL https://phabricator.kde.org/D26621 AFFECTED FILES CMakeLists.txt kstyle/CMakeLists.txt kstyle/config/CMakeLists.txt kstyle/config/oxygenstyleconfig.cpp kstyle/demo/CMakeLists.txt kstyle/demo/main.cpp kstyle/demo/oxygendemodialog.cpp kstyle/demo/oxygenframedemowidget.cpp kstyle/kstylekde4compat.cpp kstyle/kstylekde4compat.h kstyle/oxygen.h kstyle/oxygenmnemonics.cpp kstyle/oxygenshadowhelper.cpp kstyle/oxygenstyle.cpp kstyle/oxygenstyle.h kstyle/oxygenstylehelper.cpp kstyle/oxygenstylehelper.h kstyle/oxygenstyleplugin.cpp kstyle/oxygenstyleplugin.h kstyle/oxygenwindowmanager.cpp kstyle/oxygenwindowmanager.h kstyle/transitions/oxygentransitionwidget.cpp liboxygen/CMakeLists.txt liboxygen/config-liboxygen.h.cmake liboxygen/liboxygen.h liboxygen/oxygenhelper.cpp liboxygen/oxygenhelper.h liboxygen/oxygenshadowcache.cpp liboxygen/oxygenshadowconfigwidget.cpp liboxygen/oxygentileset.cpp To: zzag, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
