D26646: [Applet Configuration] Work around bad kerning in sidebar labels

[Filip Fila]

filipf abandoned this revision.
filipf added a comment.


  Should be fixed upstream https://bugreports.qt.io/browse/QTBUG-49646

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26646

To: filipf, #plasma, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26646: [Applet Configuration] Work around bad kerning in sidebar labels

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  I added a test case to https://bugreports.qt.io/browse/QTBUG-49646, BTW. 
Maybe that will help the Qt folks find the source of the issue.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-applet-config-sidebar-label-kerning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26646

To: filipf, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26646: [Applet Configuration] Work around bad kerning in sidebar labels

[Nathaniel Graham]

ngraham added subscribers: davidedmundson, mart.
ngraham added a comment.


  Yes you would need to add the margins by reducing the size of the minimum 
width.
  
  Since we found a reliable workaround, I wonder if we should just use that 
data to pinpoint the problem in Qt and fix it there... Maybe @mart or 
@davidedmundson could help with that.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26646

To: filipf, #plasma, ngraham
Cc: mart, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D26646: [Applet Configuration] Work around bad kerning in sidebar labels

[Filip Fila]

filipf updated this revision to Diff 73474.
filipf removed subscribers: mart, davidedmundson.
filipf added a comment.


  - make it work with multi line strings
  - restore side margins

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26646?vs=73473=73474

BRANCH
  fix-applet-config-sidebar-label-kerning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26646

AFFECTED FILES
  desktoppackage/contents/configuration/ConfigCategoryDelegate.qml

To: filipf, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart, davidedmundson

D26646: [Applet Configuration] Work around bad kerning in sidebar labels

[Filip Fila]

filipf added a comment.


  Oops, looks like it breaks those smallSpacing margins as well:
  
  F7881860: image.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26646

To: filipf, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26646: [Applet Configuration] Work around bad kerning in sidebar labels

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  This workaround breaks with multi-line strings: F7881852: 
Screenshot_20200113_164236.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26646

To: filipf, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26646: [Applet Configuration] Work around bad kerning in sidebar labels

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  One way that https://bugreports.qt.io/browse/QTBUG-49646 manifests itself is 
when we have single line labels centered using "horizontalAlignment: 
Text.AlignHCenter".
  
  This patch works around the kerning bug using a different centering method: 
using the layout's alignment and setting the maximum width.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-applet-config-sidebar-label-kerning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26646

AFFECTED FILES
  desktoppackage/contents/configuration/ConfigCategoryDelegate.qml

To: filipf
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart