D26660: [Task Manager]Fix and improve configuration behavior

2020-01-14 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks, this is a nice improvement, and thanks for fixing that bug which I 
caused when I originally rewrote the layout to use FormLayouts last year.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  config (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26660

To: gvgeo, #vdg, #plasma, hein, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26660: [Task Manager]Fix and improve configuration behavior

2020-01-14 Thread George Vogiatzis 
gvgeo added a comment.


  From https://bugs.kde.org/show_bug.cgi?id=415649
  Option 3 affects option 1 instead of 2.
  F7882757: Screenshot_20191229_170949.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26660

To: gvgeo, #vdg, #plasma, hein, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26660: [Task Manager]Fix and improve configuration behavior

2020-01-14 Thread George Vogiatzis 
gvgeo created this revision.
gvgeo added reviewers: VDG, Plasma, hein, ngraham.
gvgeo added a project: Plasma.
Herald added a subscriber: plasma-devel.
gvgeo requested review of this revision.

REVISION SUMMARY
  Fix the group conditions.
  Change layout.
  Rename various labels and texts.

TEST PLAN
  Before:
  The default settings, disable grouping until taskbar is full.
  The option "Group only when the Task Manager is full" is true,
  and affects grouping By program name. At the same time is disabled
  from editing, till enable "Open groups in popups".

REPOSITORY
  R119 Plasma Desktop

BRANCH
  config (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26660

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ConfigBehavior.qml

To: gvgeo, #vdg, #plasma, hein, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart