D26667: refactor about-distro to more generically support textual dumps
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R102:4b4f6a3f9639: refactor about-distro to more generically support textual dumps (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26667?vs=73708=75035#toc REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26667?vs=73708=75035 REVISION DETAIL https://phabricator.kde.org/D26667 AFFECTED FILES LICENSES/GPL-2.0-only.txt LICENSES/GPL-3.0-only.txt LICENSES/LicenseRef-KDE-Accepted-GPL.txt LICENSES/MIT.txt Modules/about-distro/src/BitEntry.cpp Modules/about-distro/src/BitEntry.h Modules/about-distro/src/CMakeLists.txt Modules/about-distro/src/CPUEntry.cpp Modules/about-distro/src/CPUEntry.h Modules/about-distro/src/Entry.cpp Modules/about-distro/src/Entry.h Modules/about-distro/src/KernelEntry.cpp Modules/about-distro/src/KernelEntry.h Modules/about-distro/src/MemoryEntry.cpp Modules/about-distro/src/MemoryEntry.h Modules/about-distro/src/Module.cpp Modules/about-distro/src/Module.h Modules/about-distro/src/Module.ui Modules/about-distro/src/PlasmaEntry.cpp Modules/about-distro/src/PlasmaEntry.h Modules/about-distro/src/SectionLabel.cpp Modules/about-distro/src/SectionLabel.h Modules/about-distro/src/main.cpp To: sitter Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26667: refactor about-distro to more generically support textual dumps
sitter added a comment. Last chance to object. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D26667 To: sitter Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26667: refactor about-distro to more generically support textual dumps
sitter updated this revision to Diff 73708. sitter added a comment. remove extra file REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26667?vs=73707=73708 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26667 AFFECTED FILES Modules/about-distro/src/BitEntry.cpp Modules/about-distro/src/BitEntry.h Modules/about-distro/src/CMakeLists.txt Modules/about-distro/src/CPUEntry.cpp Modules/about-distro/src/CPUEntry.h Modules/about-distro/src/Entry.cpp Modules/about-distro/src/Entry.h Modules/about-distro/src/KernelEntry.cpp Modules/about-distro/src/KernelEntry.h Modules/about-distro/src/MemoryEntry.cpp Modules/about-distro/src/MemoryEntry.h Modules/about-distro/src/Module.cpp Modules/about-distro/src/Module.h Modules/about-distro/src/Module.ui Modules/about-distro/src/PlasmaEntry.cpp Modules/about-distro/src/PlasmaEntry.h Modules/about-distro/src/SectionLabel.cpp Modules/about-distro/src/SectionLabel.h To: sitter Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26667: refactor about-distro to more generically support textual dumps
sitter updated this revision to Diff 73707. sitter added a comment. split into one class per file REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26667?vs=73602=73707 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26667 AFFECTED FILES Modules/about-distro/src/BitEntry.cpp Modules/about-distro/src/BitEntry.h Modules/about-distro/src/CMakeLists.txt Modules/about-distro/src/CPUEntry.cpp Modules/about-distro/src/CPUEntry.h Modules/about-distro/src/Entry.cpp Modules/about-distro/src/Entry.h Modules/about-distro/src/GPUEntry.cpp Modules/about-distro/src/GPUEntry.h Modules/about-distro/src/KernelEntry.cpp Modules/about-distro/src/KernelEntry.h Modules/about-distro/src/MemoryEntry.cpp Modules/about-distro/src/MemoryEntry.h Modules/about-distro/src/Module.cpp Modules/about-distro/src/Module.h Modules/about-distro/src/Module.ui Modules/about-distro/src/PlasmaEntry.cpp Modules/about-distro/src/PlasmaEntry.h Modules/about-distro/src/SectionLabel.cpp Modules/about-distro/src/SectionLabel.h To: sitter Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26667: refactor about-distro to more generically support textual dumps
sitter updated this revision to Diff 73602. sitter added a comment. forgot to actually write cleanup after having wanted to twice :'D REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26667?vs=73541=73602 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26667 AFFECTED FILES Modules/about-distro/src/Module.cpp Modules/about-distro/src/Module.h Modules/about-distro/src/Module.ui To: sitter Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26667: refactor about-distro to more generically support textual dumps
sitter added a comment. not sure if it's worth splitting into multiple files. personally I prefer many tiny files over one long one though *shrug*. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D26667 To: sitter Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26667: refactor about-distro to more generically support textual dumps
sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY this previously relied on manually replicating strings and whatnot, it was very awkward to read and the load functions were also getting a bit long. introducing the new entry system: generic table entries are now represented by a more generic Entry object comprised of the entry label (e.g. 'Plasma Version:') and its value (e.g. '5.17.0'). from those entries the UI is then constructed (i.e. large parts of the UI are now no longer in the designer file but rather constructed manually). all visible entries are further more collected in a global list of entries from which we'll generate the clipboard dump. localization switching is now carried out through KLocalized String instead of having string copies floating about. depending on context we'll either resolve the localized or original string. this should also make it easier to change the data set in the future, be it adding or removing new data RTL languages have a broken clipboard but it looks that was the case before as well and I utterly failed to bend it into shape with bidirectional control characters :( TEST PLAN 1. LANGUAGE=en 2. all entires shown 3. copy to clipboard dumps all entries as before 1. LANGUAGE=de 2. as above 3. copy to as english dumps in english rather than german 1. LANGUAGE=he 2. as above 3. copy in hebrew seems incorrectly order (probably because bidi algorithm falls over from both the RTL label being in the same line as the LTR numbers) REPOSITORY R102 KInfoCenter BRANCH master REVISION DETAIL https://phabricator.kde.org/D26667 AFFECTED FILES Modules/about-distro/src/Module.cpp Modules/about-distro/src/Module.h Modules/about-distro/src/Module.ui To: sitter Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
