D26739: [applets/Task Manager] Refine tooltip highlight effect

[Nathaniel Graham]

ngraham added a comment.


  Nice find. Fixed in 093e2d917ff386e627a062f3337c9ff23294e95c 
.
  
  Hopefully that's done it!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg, filipf, ndavis
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Tranter Madi]

trmdi added a comment.


  In D26739#602951 , @ngraham wrote:
  
  > Argh, now I can see it too: F8008546: weird margin.webm 

  >
  > No idea what's causing this. The code seems conceptually right to me. Maybe 
something's getting rounded up instead of down or something.
  
  
  Yep, that is. A possible solution I found is to round up `winTitle.height` 
like this: 
https://phabricator.kde.org/source/latte-dock/browse/master/plasmoid/package/contents/ui/previews/ToolTipInstance.qml$175

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg, filipf, ndavis
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Nathaniel Graham]

ngraham added a comment.


  Argh, now I can see it too: F8008546: weird margin.webm 

  
  No idea what's causing this. The code seems conceptually right to me. Maybe 
something's getting rounded up instead of down or something.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg, filipf, ndavis
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Filip Fila]

filipf added a comment.


  In D26739#602243 , @trmdi wrote:
  
  > In D26739#602082 , @filipf wrote:
  >
  > > ^ I can't reproduce that, the patch works as intended for me.  (we should 
investigate this though)
  > >
  > > One thing to just comment is that this is tailor-made for Breeze (the 1px 
thing), but it looks fine with other themes and I don't really know of any 
other solution.
  >
  >
  > Try changing the General Font size to see if you can reproduce it. On my 
system, I can reproduce it with `Noto 10`, but not with `Noto 11`.
  
  
  Still can't see it, except for this one case:
  
  F7999376: Screenshot_20200129_233038.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg, filipf, ndavis
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Tranter Madi]

trmdi added a comment.


  In D26739#602082 , @filipf wrote:
  
  > ^ I can't reproduce that, the patch works as intended for me.  (we should 
investigate this though)
  >
  > One thing to just comment is that this is tailor-made for Breeze (the 1px 
thing), but it looks fine with other themes and I don't really know of any 
other solution.
  
  
  Try changing the General Font size to see if you can reproduce it. On my 
system, I can reproduce it with `Noto 10`, but not with `Noto 11`.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg, filipf, ndavis
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:84182a554588: [applets/Task Manager] Refine tooltip 
highlight effect (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26739?vs=74475&id=74532

REVISION DETAIL
  https://phabricator.kde.org/D26739

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: ngraham, #plasma, #vdg, filipf, ndavis
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Filip Fila]

filipf accepted this revision.
filipf added a comment.
This revision is now accepted and ready to land.


  ^ I can't reproduce that, the patch works as intended for me.  (we should 
investigate this though)
  
  One thing to just comment is that this is tailor-made for Breeze (the 1px 
thing), but it looks fine with other themes and I don't really know of any 
other solution.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  tooltip-highlights-take-2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg, filipf, ndavis
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Tranter Madi]

trmdi added a comment.


  In D26739#601921 , @ngraham wrote:
  
  > In D26739#601762 , @trmdi wrote:
  >
  > > Not yet looked at the code carefully, but I feel the top margin and the 
bottom one of the thumbnail are not identical.
  >
  >
  > With the latest iteration of the patch, they should be. Feel free to try it 
out for yourself!
  
  
  Do you see this or just me?
  F7989597: image.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg, filipf, ndavis
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Nathaniel Graham]

ngraham added a comment.


  In D26739#601762 , @trmdi wrote:
  
  > Not yet looked at the code carefully, but I feel the top margin and the 
bottom one of the thumbnail are not identical.
  
  
  With the latest iteration of the patch, they should be. Feel free to try it 
out for yourself!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg, filipf, ndavis
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Tranter Madi]

trmdi added a comment.


  Not yet looked at the code carefully, but I feel the top margin and the 
bottom one of the thumbnail are not identical.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg, filipf, ndavis
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.


  LGTM

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg, filipf, ndavis
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Nathaniel Graham]

ngraham updated this revision to Diff 74475.
ngraham added a comment.


  Correct comment; last change now :)

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26739?vs=74474&id=74475

BRANCH
  tooltip-highlights-take-2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26739

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: ngraham, #plasma, #vdg, filipf, ndavis
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Noah Davis]

ndavis added a comment.


  BTW, I tried fixing the old style just to see if I wanted it more and got 
most of the way there (I had to edit the size of the 2nd Rectangle in 
`playerControlsFrostedGlass`), but realized that this new style is still better.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg, filipf, ndavis
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Nathaniel Graham]

ngraham updated this revision to Diff 74474.
ngraham added a comment.


  Fix that and also make the code simpler and more sensible

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26739?vs=74465&id=74474

BRANCH
  tooltip-highlights-take-2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26739

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: ngraham, #plasma, #vdg, filipf, ndavis
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Tranter Madi]

trmdi added a comment.


  In D26739#601666 , @ndavis wrote:
  
  > Actually, I just noticed a problem. When you hover over the bar, the 
thumbnail area gets highlighted, bit if you click on the bar, it doesn't bring 
the window to the front.
  
  
  Yes, that is what I'm asking. :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg, filipf, ndavis
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  Actually, I just noticed a problem. When you hover over the bar, the 
thumbnail area gets highlighted, bit if you click on the bar, it doesn't bring 
the window to the front.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg, filipf, ndavis
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Noah Davis]

ndavis added a comment.


  In D26739#601652 , @trmdi wrote:
  
  > What happens when you hover the mouse on the control bar? Did you address 
it?
  
  
  The buttons on the control bar use normal plasmashell toolbutton hover 
effects. The bar itself does nothing.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg, filipf, ndavis
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Tranter Madi]

trmdi added a comment.


  What happens when you hover the mouse on the control bar? Did you address it?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg, filipf, ndavis
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.


  I like this. It's pretty elegant.
  F7981156: Screenshot_20200127_202032.PNG 

  F7981150: Screenshot_20200127_201909.PNG 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg, filipf, ndavis
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Nathaniel Graham]

ngraham updated this revision to Diff 74465.
ngraham added a comment.


  Tweak pixels once more and add explanatory comments

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26739?vs=74464&id=74465

BRANCH
  tooltip-highlights-take-2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26739

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: ngraham, #plasma, #vdg, filipf
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Nathaniel Graham]

ngraham updated this revision to Diff 74464.
ngraham added a comment.


  That is nicer; let's do that instead

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26739?vs=74183&id=74464

BRANCH
  tooltip-highlights-take-2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26739

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: ngraham, #plasma, #vdg, filipf
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Tranter Madi]

trmdi added a comment.


  Pretty nice.
  But clicking on `playerControlsRow` (exclude buttons) does not behave the 
same way like clicking on the cover art, while the effect would make users 
think that they can click on the control row to open the window.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg, filipf
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Nathaniel Graham]

ngraham added a comment.


  Hmm, I can't get that to happen on my machine. :/

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg, filipf
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Noah Davis]

ndavis added a comment.


  Looks like it still needs more margin work on the bottom.
  F7918708: Screenshot_20200123_000335.PNG 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg, filipf
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Nathaniel Graham]

ngraham updated this revision to Diff 74183.
ngraham added a comment.


  Fix the margins for the window thumbnail too

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26739?vs=74180&id=74183

BRANCH
  tooltip-highlights-take-2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26739

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: ngraham, #plasma, #vdg, filipf
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Nathaniel Graham]

ngraham updated this revision to Diff 74180.
ngraham added a comment.


  Fix the rebase

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26739?vs=74179&id=74180

BRANCH
  tooltip-highlights-take-2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26739

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: ngraham, #plasma, #vdg, filipf
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Nathaniel Graham]

ngraham updated this revision to Diff 74179.
ngraham added a comment.


  Rebase

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26739?vs=73984&id=74179

BRANCH
  refine-tooltip-highlight-effects (branched from Plasma/5.18)

REVISION DETAIL
  https://phabricator.kde.org/D26739

AFFECTED FILES
  CMakeLists.txt
  HACKING
  applets/kicker/package/metadata.desktop
  applets/kimpanel/backend/ibus/emojier/org.kde.plasma.emojier.desktop
  applets/minimizeall/package/contents/ui/main.qml
  applets/minimizeall/package/metadata.desktop
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml
  desktoppackage/contents/explorer/WidgetExplorer.qml
  kcms/activities/ActivitiesTab.cpp
  kcms/activities/ActivitiesTab.h
  kcms/activities/BlacklistedApplicationsModel.cpp
  kcms/activities/BlacklistedApplicationsModel.h
  kcms/activities/MainConfigurationWidget.cpp
  kcms/activities/MainConfigurationWidget.h
  kcms/activities/PrivacyTab.cpp
  kcms/activities/PrivacyTab.h
  kcms/activities/SwitchingTab.cpp
  kcms/activities/SwitchingTab.h
  kcms/activities/kactivitymanagerd_plugins_settings.kcfg
  kcms/activities/ui/PrivacyTabBase.ui
  kcms/activities/ui/SwitchingTabBase.ui
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/filteredfoldermodel.h
  kcms/baloo/kcm.cpp
  kcms/baloo/kcm.h
  kcms/baloo/package/contents/ui/main.qml
  kcms/baloo/package/metadata.desktop
  kcms/colors/colorschemes.knsrc
  kcms/colors/editor/org.kde.kcolorschemeeditor.desktop
  kcms/componentchooser/browserconfig_ui.ui
  kcms/componentchooser/componentchooser.cpp
  kcms/componentchooser/componentchooser_ui.ui
  kcms/componentchooser/componentchooserbrowser.cpp
  kcms/componentchooser/componentchooserbrowser.h
  kcms/componentchooser/componentchooseremail.cpp
  kcms/componentchooser/componentchooseremail.h
  kcms/componentchooser/componentchooserfilemanager.cpp
  kcms/componentchooser/componentchooserfilemanager.h
  kcms/componentchooser/componentchooserterminal.cpp
  kcms/componentchooser/componentchooserterminal.h
  kcms/componentchooser/emailclientconfig_ui.ui
  kcms/componentchooser/filemanagerconfig_ui.ui
  kcms/componentchooser/terminalemulatorconfig_ui.ui
  kcms/hardware/joystick/joystick.cpp
  kcms/kded/CMakeLists.txt
  kcms/kded/filterproxymodel.cpp
  kcms/kded/filterproxymodel.h
  kcms/kded/kcmkded.cpp
  kcms/kded/kcmkded.desktop
  kcms/kded/kcmkded.h
  kcms/kded/modulesmodel.cpp
  kcms/kded/modulesmodel.h
  kcms/kded/package/contents/ui/main.qml
  kcms/kded/package/metadata.desktop
  kcms/kfontinst/kio/KioFonts.cpp
  kcms/kfontinst/kio/KioFonts.h
  kcms/launch/kcm_launchfeedback.desktop
  kcms/launch/package/metadata.desktop
  kcms/nightcolor/kcm_nightcolor.desktop
  kcms/nightcolor/package/metadata.desktop
  kcms/notifications/kcm.cpp
  kcms/notifications/kcm.h
  kcms/notifications/package/contents/ui/PopupPositionPage.qml
  kcms/notifications/package/contents/ui/main.qml
  kcms/solid_actions/solid-actions.desktop
  kcms/style/CMakeLists.txt
  kcms/style/cgcgtk3.knsrc
  kcms/style/cgctheme.knsrc
  kcms/style/gtk2_themes.knsrc
  kcms/style/gtk3_themes.knsrc
  kcms/style/gtkpage.cpp
  kcms/style/gtkpage.h
  kcms/style/gtkthemesmodel.h
  kcms/style/package/contents/ui/GtkStylePage.qml
  kcms/workspaceoptions/kcm_workspace.desktop
  kcms/workspaceoptions/package/metadata.desktop
  solid-device-automounter/kcm/device_automounter_kcm.desktop

To: ngraham, #plasma, #vdg, filipf
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Noah Davis]

ndavis added a comment.


  This needs to be rebased.
  
  In D26739#597836 , @ngraham wrote:
  
  > Better, less disruptive version
  
  
  It doesn't look right on programs with no album art. Something is wrong with 
the margins.
  F7906928: Screenshot_20200122_112428.PNG 

  
  However, this looks pretty good:
  F7907006: Screenshot_20200122_112816.PNG 

  
  Seems like the horizontal margins need to be extended very slightly.
  
  In D26739#597656 , @trmdi wrote:
  
  > How about this?
  >
  > F7894214: vokoscreen-2020-01-20_23-10-29.mp4 

  
  
  I think this looks pretty good. Maybe it's just because I'm not used to it 
yet, but I kind of prefer having the background highlight take up all the 
height for all task manager previews.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg, filipf
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Nathaniel Graham]

ngraham updated this revision to Diff 73984.
ngraham marked an inline comment as done.
ngraham added a comment.


  Better, less disruptive version

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26739?vs=73795&id=73984

BRANCH
  refine-tooltip-highlight-effects (branched from Plasma/5.18)

REVISION DETAIL
  https://phabricator.kde.org/D26739

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: ngraham, #plasma, #vdg, filipf
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Tranter Madi]

trmdi added a comment.


  How about this?
  
  F7894214: vokoscreen-2020-01-20_23-10-29.mp4 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg, filipf
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Tranter Madi]

trmdi added a comment.


  Could you clarify before/after screenshots?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg, filipf
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Filip Fila]

filipf requested changes to this revision.
filipf added a comment.
This revision now requires changes to proceed.


  I think what Noah means is that the media controls row should perfectly touch 
the left, right and bottom border. The margins in this patch are too big so 
they effectively create another frame in a frame.
  
  But what's more important is that having the highlight effect above 
everything just doesn't work with themes that have a filled highlight style. We 
should scrap that idea.
  
  F7889878: Screenshot_20200118_120047.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg, filipf
Cc: filipf, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Nathaniel Graham]

ngraham added a comment.


  In D26739#596363 , @ndavis wrote:
  
  > You can't shrink the size of it to fit within the blue border?
  
  
  That's what this patch does in its current form.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg
Cc: filipf, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Noah Davis]

ndavis added a comment.


  In D26739#596355 , @ngraham wrote:
  
  > Yeah. I don't disagree. But if I just ensure that the highlight effect is 
the highest item, the borders still get obscured by the player controls and 
album art. And the rounded corners of the highlight leave a pixel or two of the 
art to escape the bounds too.
  >
  > F7889322: Screenshot_20200117_213837.png 

  
  
  You can't shrink the size of it to fit within the blue border?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg
Cc: filipf, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Noah Davis]

ndavis added inline comments.

INLINE COMMENTS

> ToolTipInstance.qml:185
>  pressed: hoverHandler.containsPress
> +z: 
>  }

I recall seeing a QML dos and don'ts webinar that said not to use large z 
values.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg
Cc: filipf, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Nathaniel Graham]

ngraham added a comment.


  Yeah. I don't disagree. But if I just ensure that the highlight effect is the 
highest item, the borders still get obscured by the player controls and album 
art. And the rounded corners of the highlight leave a pixel or two of the art 
to escape the bounds too.
  
  F7889322: Screenshot_20200117_213837.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg
Cc: filipf, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Filip Fila]

filipf added a comment.


  In D26739#596320 , @ndavis wrote:
  
  > Not a fan of the inner frame. We should avoid making frames within frames. 
I don't think it really needs changing, except that the sides cover the blue 
border frame.
  >
  > F7889165: Screenshot_20200117_211120.PNG 

  
  
  +1

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg
Cc: filipf, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Noah Davis]

ndavis added a comment.


  Not a fan of the inner frame. We should avoid making frames within frames. I 
don't think it really needs changing, except that the sides cover the blue 
border frame.
  
  F7889165: Screenshot_20200117_211120.PNG 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Nathaniel Graham]

ngraham added a comment.


  I'm not 100% sold on drawing the highlight on top and tinting everything, and 
can revert that part if everyone else hates it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch implements the following visual tweaks:
  
  - Draws the highlight effect on top so that it tints the content
  - Indents the media controls by `units.smallSpacing` to match the window 
thumbnail
  
  Now the boundaries of the highlight effect don't get overlapped by the 
content inside,
  and the highlight effect is more visible for tooltips where the thumbnail or 
album art
  takes up most of the space.
  
  BUG: 416390
  FIXED-IN: 5.18.0

TEST PLAN
  F7888903: After, with album art.png 
  F7888902: After, thumbnail with no media controls.png 

  F7888901: After, no album art and unminimized.png 

  F7888900: After, no album art and minimized.png 


REPOSITORY
  R119 Plasma Desktop

BRANCH
  refine-tooltip-highlight-effects (branched from Plasma/5.18)

REVISION DETAIL
  https://phabricator.kde.org/D26739

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: ngraham, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart