D26881: [Applets/Folder View] Allow using a folder that ends with a space
ngraham abandoned this revision. ngraham added a comment. What a silly little patch this was. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26881 To: ngraham, hein, #plasma Cc: anthonyfieroni, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26881: [Applets/Folder View] Allow using a folder that ends with a space
anthonyfieroni added a comment. If url ends with more than one space? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26881 To: ngraham, hein, #plasma Cc: anthonyfieroni, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26881: [Applets/Folder View] Allow using a folder that ends with a space
broulik added a comment. That's somewhat oddly spcific, isn't it? I'd be surprised that `fromLocalFile` strips trailing spaces? :0 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26881 To: ngraham, hein, #plasma Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26881: [Applets/Folder View] Allow using a folder that ends with a space
ngraham created this revision. ngraham added reviewers: hein, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY `QUrl::fromLocalFile` is otherwise appropriate but automatically strips a trailing space, which we don't want. This patch explicitly handles that case. CCBUG: 407671 TEST PLAN Configure Folder View applet Enter a valid path to a folder whose name ends with a space It works REPOSITORY R119 Plasma Desktop BRANCH allow-adding-folders-that-end-with-a-space (branched from master) REVISION DETAIL https://phabricator.kde.org/D26881 AFFECTED FILES containments/desktop/plugins/folder/foldermodel.cpp To: ngraham, hein, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart