D26978: [kstyle] Use QX11Info::isCompositingManagerRunning()

[Vlad Zahorodnii]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:932e5dc45410: [kstyle] Use 
QX11Info::isCompositingManagerRunning() (authored by zzag).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26978?vs=74606&id=74608

REVISION DETAIL
  https://phabricator.kde.org/D26978

AFFECTED FILES
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h

To: zzag, #plasma, hpereiradacosta
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26978: [kstyle] Use QX11Info::isCompositingManagerRunning()

[Vlad Zahorodnii]

zzag updated this revision to Diff 74606.
zzag added a comment.


  update

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26978?vs=74598&id=74606

BRANCH
  use-qx11info-is-compositing-manager-active

REVISION DETAIL
  https://phabricator.kde.org/D26978

AFFECTED FILES
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h

To: zzag, #plasma, hpereiradacosta
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26978: [kstyle] Use QX11Info::isCompositingManagerRunning()

[Vlad Zahorodnii]

zzag added a comment.


  In D26978#602655 , 
@hpereiradacosta wrote:
  
  > In principle, the removal of Helper::connection, although is a change 
unrelated to the commit purpose. Maybe put it in a different commit ?
  
  
  Will do. (I removed it as a preparation step for `QWindow::startSystemMove()`)

REPOSITORY
  R31 Breeze

BRANCH
  use-qx11info-is-compositing-manager-active

REVISION DETAIL
  https://phabricator.kde.org/D26978

To: zzag, #plasma, hpereiradacosta
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26978: [kstyle] Use QX11Info::isCompositingManagerRunning()

[Hugo Pereira Da Costa]

hpereiradacosta accepted this revision.
hpereiradacosta added a comment.
This revision is now accepted and ready to land.


  Makes sense, thanks !
  
  In principle, the removal of Helper::connection, although is a change 
unrelated to the commit purpose. Maybe put it in a different commit ? 
  (the story behind if I remember right is that QX11Info::connection have not 
always been available in the past. hence the method)

REPOSITORY
  R31 Breeze

BRANCH
  use-qx11info-is-compositing-manager-active

REVISION DETAIL
  https://phabricator.kde.org/D26978

To: zzag, #plasma, hpereiradacosta
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26978: [kstyle] Use QX11Info::isCompositingManagerRunning()

[Vlad Zahorodnii]

zzag updated this revision to Diff 74598.
zzag added a comment.


  Fix coding style.

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26978?vs=74539&id=74598

BRANCH
  use-qx11info-is-compositing-manager-active

REVISION DETAIL
  https://phabricator.kde.org/D26978

AFFECTED FILES
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezewindowmanager.cpp

To: zzag, #plasma, hpereiradacosta
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26978: [kstyle] Use QX11Info::isCompositingManagerRunning()

[Vlad Zahorodnii]

zzag added a comment.


  > monitors compositing manager selections
  
  Only if XFIXES is present; otherwise it will fallback to 
`xcb_get_selection_owner` as Breeze does now.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26978

To: zzag, #plasma, hpereiradacosta
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26978: [kstyle] Use QX11Info::isCompositingManagerRunning()

[Vlad Zahorodnii]

zzag created this revision.
zzag added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
zzag requested review of this revision.

REVISION SUMMARY
  Every time Breeze needs to check whether given widget has an alpha
  channel, it makes a synchronous X call to figure out whether a
  compositing window manager is running on a particular screen. This
  is inefficient!
  
  Luckily for us, Qt XCB QPA monitors compositing manager selections
  and caches the ownership status of each one. That cached ownership
  data can be accessed via QX11Info::isCompositingManagerRunning().

REPOSITORY
  R31 Breeze

BRANCH
  use-qx11info-is-compositing-manager-active

REVISION DETAIL
  https://phabricator.kde.org/D26978

AFFECTED FILES
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezewindowmanager.cpp

To: zzag, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart