D26993: [libkworkspace] Introduce UpdateLaunchEnvJob
This revision was automatically updated to reflect the committed changes. Closed by commit R120:6253163af827: [libkworkspace] Introduce UpdateLaunchEnvJob (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26993?vs=74668&id=74669 REVISION DETAIL https://phabricator.kde.org/D26993 AFFECTED FILES libkworkspace/CMakeLists.txt libkworkspace/updatelaunchenvjob.cpp libkworkspace/updatelaunchenvjob.h To: broulik, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26993: [libkworkspace] Introduce UpdateLaunchEnvJob
broulik updated this revision to Diff 74668. broulik added a comment. - docs REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26993?vs=74587&id=74668 REVISION DETAIL https://phabricator.kde.org/D26993 AFFECTED FILES libkworkspace/CMakeLists.txt libkworkspace/updatelaunchenvjob.cpp libkworkspace/updatelaunchenvjob.h To: broulik, #plasma Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26993: [libkworkspace] Introduce UpdateLaunchEnvJob
davidedmundson added inline comments.
INLINE COMMENTS
> updatelaunchenvjob.h:28
> +
> +class KWORKSPACE_EXPORT UpdateLaunchEnvJob : public KJob
> +{
Docs
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D26993
To: broulik, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh,
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26993: [libkworkspace] Introduce UpdateLaunchEnvJob
davidedmundson added a comment.
+++
Lets port some usages, so we can confirm it works in practice, but this looks
good
INLINE COMMENTS
> updatelaunchenvjob.cpp:79
> +
> +// Startup (effectively KSMServer)
> +org::kde::Startup startup(QStringLiteral("org.kde.Startup"),
Not quite. It's plasma-session
It spawns processes, which in turn might update the launch env, that we should
have that env when we spawn the next round of processes.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D26993
To: broulik, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh,
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D26993: [libkworkspace] Introduce UpdateLaunchEnvJob
broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This is supposed to replace manual DBus calls to `KLauncher` `setLaunchEnv` done in e.g. the KCMs, so this can easily be extended in the future. TEST PLAN - Successfully changed an env variable REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26993 AFFECTED FILES libkworkspace/CMakeLists.txt libkworkspace/updatelaunchenvjob.cpp libkworkspace/updatelaunchenvjob.h To: broulik, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
