D27019: Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess
This revision was automatically updated to reflect the committed changes. Closed by commit R119:5eb5c9ab7d7e: Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27019?vs=74767=74890 REVISION DETAIL https://phabricator.kde.org/D27019 AFFECTED FILES solid-device-automounter/kcm/DeviceModel.cpp To: meven, #plasma, broulik, ngraham, ervin Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27019: Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess
meven updated this revision to Diff 74767. meven added a comment. Don't list ignored devices as intended REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27019?vs=74656=74767 BRANCH arcpatch-D27019 REVISION DETAIL https://phabricator.kde.org/D27019 AFFECTED FILES solid-device-automounter/kcm/DeviceModel.cpp To: meven, #plasma, broulik, ngraham, ervin Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27019: Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess
ngraham added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27019 To: meven, #plasma, broulik, ngraham, ervin Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27019: Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess
meven added inline comments. INLINE COMMENTS > broulik wrote in DeviceModel.cpp:119 > Do we want to add items that are *not* a `StorageAccess`? > Shouldn't this be more like > > if (access && !access->isIgnored())` I needed to add the not mounted storage access as storage access ignores not mounted system REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27019 To: meven, #plasma, broulik, ngraham, ervin Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27019: Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess
meven updated this revision to Diff 74656. meven added a comment. Checking if this is a not-ignored or not mounted StorageAccess is what we need REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27019?vs=74654=74656 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27019 AFFECTED FILES solid-device-automounter/kcm/DeviceModel.cpp To: meven, #plasma, broulik, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27019: Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess
meven updated this revision to Diff 74654. meven marked an inline comment as done. meven added a comment. Only display device that are not ignored Solid::StorageVolume and Solid::StorageAccess REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27019?vs=74649=74654 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27019 AFFECTED FILES solid-device-automounter/kcm/DeviceModel.cpp To: meven, #plasma, broulik, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27019: Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess
broulik added inline comments.
INLINE COMMENTS
> DeviceModel.cpp:119
> +const Solid::StorageAccess *access = dev.as();
> +if (access == nullptr || !access->isIgnored()) {
> +beginInsertRows(index(0, 0), m_attached.size(),
> m_attached.size());
Do we want to add items that are *not* a `StorageAccess`?
Shouldn't this be more like
if (access && !access->isIgnored())`
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D27019
To: meven, #plasma, broulik, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27019: Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess
meven updated this revision to Diff 74649. meven added a comment. Separate foreach conversions REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27019?vs=74647=74649 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27019 AFFECTED FILES solid-device-automounter/kcm/DeviceModel.cpp To: meven, #plasma, broulik, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27019: Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess
broulik added a comment. Can we do the foreach ports separately, please REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27019 To: meven, #plasma, broulik, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27019: Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess
meven created this revision. meven added reviewers: Plasma, broulik, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY BUG: 396537 FIXED-IN: 5.18 REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D27019 AFFECTED FILES solid-device-automounter/kcm/DeviceAutomounterKCM.cpp solid-device-automounter/kcm/DeviceModel.cpp To: meven, #plasma, broulik, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
