D27029: Remove header top margin from private ScrollView

2020-01-31 Thread Arjen Hiemstra
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:da3d41f13690: Remove header top margin from private 
ScrollView (authored by ahiemstra).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27029?vs=74677&id=74784

REVISION DETAIL
  https://phabricator.kde.org/D27029

AFFECTED FILES
  src/controls/templates/private/ScrollView.qml

To: ahiemstra, #kirigami, ngraham, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein


D27029: Remove header top margin from private ScrollView

2020-01-30 Thread Arjen Hiemstra
ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  With the scrollbars taking up actual width, the top margin of the vertical
  scrollbar being set to the list header looks really awkward and buggy. This
  removes the top margin, making the scrollbar take the entire flickable's
  height. This change also applies to overlay scrollbars as I consider the
  margin behaviour to be incorrect even for those, as the top margin will
  change based on the header height, which causes the scrollbar to resize
  when the header shrinks.

REPOSITORY
  R169 Kirigami

BRANCH
  scrollbar_topmargin

REVISION DETAIL
  https://phabricator.kde.org/D27029

AFFECTED FILES
  src/controls/templates/private/ScrollView.qml

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein