D27100: [GTK Config] Parameterise GTK config editing

2020-04-02 Thread Mikhail Zolotukhin 
This revision was automatically updated to reflect the committed changes.
Closed by commit R99:0580098ab4cd: [GTK Config] Parameterise GTK config editing 
(authored by gikari).

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27100?vs=79089=79156

REVISION DETAIL
  https://phabricator.kde.org/D27100

AFFECTED FILES
  kconf_update/gtktheme.cpp
  kded/CMakeLists.txt
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp

To: gikari, #plasma, cblack
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27100: [GTK Config] Parameterise GTK config editing

2020-04-01 Thread Mikhail Zolotukhin 
gikari updated this revision to Diff 79089.
gikari marked 2 inline comments as done.
gikari added a comment.


  - Remove `explicit` QVariant wrappers

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27100?vs=77909=79089

BRANCH
  arcpatch-D27100

REVISION DETAIL
  https://phabricator.kde.org/D27100

AFFECTED FILES
  kconf_update/gtktheme.cpp
  kded/CMakeLists.txt
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp

To: gikari, #plasma, cblack
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27100: [GTK Config] Parameterise GTK config editing

2020-04-01 Thread Carson Black 
cblack accepted this revision.
cblack added a comment.
This revision is now accepted and ready to land.


  Besides one minor over-verbosity issue, this looks like shipit material to 
me. Drop the QVariant() wrappers (but don't drop the `#include`) before 
landing, please.

INLINE COMMENTS

> gtktheme.cpp:42
>  ) {
> -ConfigEditor::setGtk2ConfigValue(QStringLiteral("gtk-theme-name"), 
> QStringLiteral("Breeze"));
> +ConfigEditor::setGtk2ConfigValue(QStringLiteral("gtk-theme-name"), 
> QVariant(QStringLiteral("Breeze")));
>  }

You don't need to wrap the QStringLiteral with a QVariant here

> gtktheme.cpp:53-55
> +
> ConfigEditor::setGtk3ConfigValueGSettings(QStringLiteral("gtk-theme"), 
> QVariant(QStringLiteral("Breeze")));
> +
> ConfigEditor::setGtk3ConfigValueSettingsIni(QStringLiteral("gtk-theme-name"), 
> QVariant(QStringLiteral("Breeze")));
> +
> ConfigEditor::setGtk3ConfigValueXSettingsd(QStringLiteral("Net/ThemeName"), 
> QVariant(QStringLiteral("Breeze")));

Ditto here

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  parameterise-gtk-config-io (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27100

To: gikari, #plasma, cblack
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27100: [GTK Config] Parameterise GTK config editing

2020-04-01 Thread Mikhail Zolotukhin 
gikari added a comment.


  Ping

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27100

To: gikari, #plasma, cblack
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27100: [GTK Config] Parameterise GTK config editing

2020-03-18 Thread Mikhail Zolotukhin 
gikari updated this revision to Diff 77909.
gikari added a comment.


  Rebase on master

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27100?vs=77185=77909

BRANCH
  parameterise-gtk-config-io (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27100

AFFECTED FILES
  kconf_update/gtktheme.cpp
  kded/CMakeLists.txt
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp

To: gikari, #plasma, cblack
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27100: [GTK Config] Parameterise GTK config editing

2020-03-16 Thread Mikhail Zolotukhin 
gikari added a comment.


  Ping

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27100

To: gikari, #plasma, cblack
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27100: [GTK Config] Parameterise GTK config editing

2020-03-07 Thread Mikhail Zolotukhin 
gikari updated this revision to Diff 77185.
gikari added a comment.


  Use `arg` instead of + + + + + +

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27100?vs=74855=77185

BRANCH
  parameterise-gtk-config-io (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27100

AFFECTED FILES
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp

To: gikari, #plasma, cblack
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27100: [GTK Config] Parameterise GTK config editing

2020-02-26 Thread Mikhail Zolotukhin 
gikari added a comment.


  In D27100#617732 , @cblack wrote:
  
  > There's a lot of string concatenation going on. I would replace a lot of 
the instances where you concat more than 2 strings with QString's arg function 
for readability purposes.
  
  
  If you do not mind, I will introduce operators refactoring in another patch. 
If it is done here, it will convolute the diff - what I've done here does not 
change the concatenation mechanics.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27100

To: gikari, #plasma, cblack
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27100: [GTK Config] Parameterise GTK config editing

2020-02-25 Thread Carson Black 
cblack requested changes to this revision.
cblack added a comment.
This revision now requires changes to proceed.


  There's a lot of string concatenation going on. I would replace a lot of the 
instances where you concat more than 2 strings with QString's arg function for 
readability purposes.
  
  Will review more thoroughly when I get the time.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27100

To: gikari, #plasma, cblack
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart