D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

[Carson Black]

cblack updated this revision to Diff 75144.
cblack added a comment.


  Swap in gridUnit instead of largeSpacing

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27160?vs=75143&id=75144

BRANCH
  media-plasmoid-relayout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27160

AFFECTED FILES
  applets/mediacontroller/contents/config/config.qml
  applets/mediacontroller/contents/config/main.xml
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml
  applets/mediacontroller/contents/ui/configView.qml
  applets/mediacontroller/contents/ui/main.qml

To: cblack, #vdg, #plasma, manueljlin
Cc: iasensio, ndavis, broulik, gvgeo, davidedmundson, ngraham, manueljlin, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

[Carson Black]

cblack updated this revision to Diff 75143.
cblack added a comment.


  Remove extraneous print

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27160?vs=75142&id=75143

BRANCH
  media-plasmoid-relayout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27160

AFFECTED FILES
  applets/mediacontroller/contents/config/config.qml
  applets/mediacontroller/contents/config/main.xml
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml
  applets/mediacontroller/contents/ui/configView.qml
  applets/mediacontroller/contents/ui/main.qml

To: cblack, #vdg, #plasma, manueljlin
Cc: iasensio, ndavis, broulik, gvgeo, davidedmundson, ngraham, manueljlin, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

[Carson Black]

cblack updated this revision to Diff 75142.
cblack added a comment.


  Add license headers to two new QML files

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27160?vs=75141&id=75142

BRANCH
  media-plasmoid-relayout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27160

AFFECTED FILES
  applets/mediacontroller/contents/config/config.qml
  applets/mediacontroller/contents/config/main.xml
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml
  applets/mediacontroller/contents/ui/configView.qml
  applets/mediacontroller/contents/ui/main.qml

To: cblack, #vdg, #plasma, manueljlin
Cc: iasensio, ndavis, broulik, gvgeo, davidedmundson, ngraham, manueljlin, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

[Carson Black]

cblack updated this revision to Diff 75141.
cblack added a comment.


  Move source selector to bottom of column, hide by default

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27160?vs=75140&id=75141

BRANCH
  media-plasmoid-relayout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27160

AFFECTED FILES
  applets/mediacontroller/contents/config/config.qml
  applets/mediacontroller/contents/config/main.xml
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml
  applets/mediacontroller/contents/ui/configView.qml
  applets/mediacontroller/contents/ui/main.qml

To: cblack, #vdg, #plasma, manueljlin
Cc: iasensio, ndavis, broulik, gvgeo, davidedmundson, ngraham, manueljlin, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

[Carson Black]

cblack updated this revision to Diff 75140.
cblack marked 7 inline comments as done.
cblack added a comment.


  Address feedback

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27160?vs=75138&id=75140

BRANCH
  media-plasmoid-relayout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27160

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml
  applets/mediacontroller/contents/ui/main.qml

To: cblack, #vdg, #plasma, manueljlin
Cc: iasensio, ndavis, broulik, gvgeo, davidedmundson, ngraham, manueljlin, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

[Carson Black]

cblack marked an inline comment as done.
cblack added inline comments.

INLINE COMMENTS

> broulik wrote in ExpandedRepresentation.qml:145-148
> Do you have a source for this claim? From what I know blur merely blurs the 
> actual item texture which is rendered, no the raw image source?

https://github.com/qt/qtdeclarative/blob/9893e71cea5de10193376c1733db627ef0783614/src/quick/items/qquickimage.cpp#L600-L603

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27160

To: cblack, #vdg, #plasma, manueljlin
Cc: iasensio, ndavis, broulik, gvgeo, davidedmundson, ngraham, manueljlin, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

[Carson Black]

cblack updated this revision to Diff 75138.
cblack added a comment.


  Cache data from the MPRIS sources

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27160?vs=75077&id=75138

BRANCH
  media-plasmoid-relayout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27160

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml
  applets/mediacontroller/contents/ui/main.qml

To: cblack, #vdg, #plasma, manueljlin
Cc: iasensio, ndavis, broulik, gvgeo, davidedmundson, ngraham, manueljlin, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

[Carson Black]

cblack updated this revision to Diff 75077.
cblack added a comment.


  Use toolbutton (for initial visual feedback; need to apply colour scheme as 
to prevent legibility issues)

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27160?vs=75076&id=75077

BRANCH
  media-plasmoid-relayout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27160

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml

To: cblack, #vdg, #plasma, manueljlin
Cc: ndavis, broulik, gvgeo, davidedmundson, ngraham, manueljlin, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

[Nathaniel Graham]

ngraham added a comment.


  Yeah at least with text on the side, tabs won't work at all for smaller 
sizes, such as in the system tray: F8087543: Screenshot_20200205_193710.png 

  
  That's with just two sources!
  
  If the text were on the bottom and it was limited to wide sizes, I could 
maybe see that working.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27160

To: cblack, #vdg, #plasma, manueljlin
Cc: ndavis, broulik, gvgeo, davidedmundson, ngraham, manueljlin, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

[Noah Davis]

ndavis added a comment.


  Looks like my previous comment is obsolete. I think tabs are more convenient 
than a combo box in this case, but I'm not sure this is the best use of tabs. 
AFAIK, we never use tabs as an actual selection control anywhere, so this 
behavior is unexpected.
  
  Or are these actually different views for controlling all the applications 
separately rather than just switching sources?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27160

To: cblack, #vdg, #plasma, manueljlin
Cc: ndavis, broulik, gvgeo, davidedmundson, ngraham, manueljlin, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

[Carson Black]

cblack updated this revision to Diff 75076.
cblack added a comment.


  Fix plasmashell freeze

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27160?vs=75075&id=75076

BRANCH
  media-plasmoid-relayout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27160

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml

To: cblack, #vdg, #plasma, manueljlin
Cc: ndavis, broulik, gvgeo, davidedmundson, ngraham, manueljlin, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

[Noah Davis]

ndavis added a comment.


  I don't think putting the source selector on the bottom is better. It moves 
the buttons farther away from where the mouse would be when opening the widget 
on a default panel.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27160

To: cblack, #vdg, #plasma, manueljlin
Cc: ndavis, broulik, gvgeo, davidedmundson, ngraham, manueljlin, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

[Carson Black]

cblack updated this revision to Diff 75075.
cblack marked an inline comment as done.
cblack added a comment.


  Address feedback

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27160?vs=75025&id=75075

BRANCH
  media-plasmoid-relayout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27160

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml

To: cblack, #vdg, #plasma, manueljlin
Cc: broulik, gvgeo, davidedmundson, ngraham, manueljlin, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

[Kai Uwe Broulik]

broulik added a comment.


  When there is no player it completely falls apart. It also doesn't work when 
there is no album art. The fallback player icon is gone.
  F8086262: Screenshot_20200205_093259.PNG 

  
  The line spacing also seems a little excessive. Since there's a massive right 
padding to match the one on the left, you often end up with awkward line breaks:
  F8086264: Screenshot_20200205_093515.PNG 

  Note how the "seh" could have easily fitted in the same line. It now also 
looks a bit awkward when you can't seek where there's no slider handle.
  
  It looks really lovely with short texts
  F8086272: Screenshot_20200205_093836.PNG 

  but you know...
  F8086274: Screenshot_20200205_094303.PNG 

  And obviously I would prefer a better look for the player selection combo :)

INLINE COMMENTS

> ExpandedRepresentation.qml:137
> +Layout.margins: units.smallSpacing
> +Layout.alignment: Qt.AlignHCenter
> +Layout.fillWidth: true

Superfluous since you fill both width and height?

> ExpandedRepresentation.qml:145-148
> +sourceSize.width: 512 /* Setting a source size means the 
> item doesn't need
> +to recompute blur as the user 
> resizes the plasmoid
> +Additionally, it puts a bit of a cap 
> on how large the
> +buffer getting blurred can be, 
> saving resources.

Do you have a source for this claim? From what I know blur merely blurs the 
actual item texture which is rendered, no the raw image source?

> ExpandedRepresentation.qml:205
> +
> +color: softwareRendering ? undefined : "white"
>  

Does assigning `undefined` work? I don't see a `RESET` property for it. 
Probably want to assign color scope text color instead?

> ExpandedRepresentation.qml:212
>  
> -source: mpris2Source.currentData["Desktop Icon Name"]
> -visible: !albumArt.visible
> +Layout.maximumWidth: expandedRepresentation.width * 
> (2/5)
> +}

Make sure to `Math.round` random factors of a size

> ExpandedRepresentation.qml:289
> +Layout.fillWidth: true
> +Layout.maximumWidth: Math.min(800, 
> expandedRepresentation.width*(7/10))
> +

No magic numbers, please

> ExpandedRepresentation.qml:306
>  font: theme.smallestFont
> +color: softwareRendering ? undefined : "white"
>  }

The labels are shown outside the album art, so they are unreadable now

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27160

To: cblack, #vdg, #plasma, manueljlin
Cc: broulik, gvgeo, davidedmundson, ngraham, manueljlin, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

[George Vogiatzis]

gvgeo added a comment.


  Maybe I'm wrong, don't give too much weight on these comments.

INLINE COMMENTS

> ExpandedRepresentation.qml:212
>  
> -source: mpris2Source.currentData["Desktop Icon Name"]
> -visible: !albumArt.visible
> +Layout.maximumWidth: expandedRepresentation.width * 
> (2/5)
> +}

You are limiting `Details Column`'s width, while `Album Art` is not always 
visible.

> ExpandedRepresentation.qml:216
> +id: songArtist
> +visible: root.track && root.artist
> +level: 2

With a white theme?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27160

To: cblack, #vdg, #plasma, manueljlin
Cc: gvgeo, davidedmundson, ngraham, manueljlin, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

[Manuel Jesús de la Fuente]

manueljlin added a comment.


  I love how it looks :D
  The only thing I would change is the progress bar padding by either extending 
the bar to the left border to the album art or to the ~11px border from before

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27160

To: cblack, #vdg, #plasma, manueljlin
Cc: davidedmundson, ngraham, manueljlin, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> ExpandedRepresentation.qml:410
> +
> +width: Math.round(0.6 * parent.width)
> +height: visible ? undefined : 0

Items in a layout shouldn't specify a width

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27160

To: cblack, #vdg, #plasma, manueljlin
Cc: davidedmundson, ngraham, manueljlin, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> cblack wrote in ExpandedRepresentation.qml:249
> F8085988: image.png 

All right, looks good!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27160

To: cblack, #vdg, #plasma, manueljlin
Cc: ngraham, manueljlin, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

[Carson Black]

cblack marked an inline comment as done.
cblack added inline comments.

INLINE COMMENTS

> ngraham wrote in ExpandedRepresentation.qml:249
> Is a hardcoded white color always guaranteed to look good even when the album 
> art is very light? Is the blurred background always going to be dark enough?

F8085988: image.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27160

To: cblack, #vdg, #plasma, manueljlin
Cc: ngraham, manueljlin, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

[Carson Black]

cblack updated this revision to Diff 75025.
cblack marked an inline comment as done.
cblack added a comment.


  Adjust layout of components

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27160?vs=75023&id=75025

BRANCH
  media-plasmoid-relayout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27160

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml

To: cblack, #vdg, #plasma, manueljlin
Cc: ngraham, manueljlin, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

[Carson Black]

cblack marked 2 inline comments as done.
cblack added inline comments.

INLINE COMMENTS

> ngraham wrote in ExpandedRepresentation.qml:178
> whitespace

Whitespace is intentional to help with code legibility

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27160

To: cblack, #vdg, #plasma, manueljlin
Cc: ngraham, manueljlin, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

[Nathaniel Graham]

ngraham added subscribers: manueljlin, ngraham.
ngraham added a reviewer: manueljlin.
ngraham added a comment.


  Overall very nice. I think it's a good visual direction. However it's not 
totally consistent with @manueljlin's mockups in T10470 
 so let's make sure he's happy too.

INLINE COMMENTS

> ExpandedRepresentation.qml:178
> +height: visible ? undefined : 0
> +
> +textRole: "text"

whitespace

> ExpandedRepresentation.qml:180
> +textRole: "text"
> +
> +Layout.alignment: Qt.AlignHCenter

whitespace

> ExpandedRepresentation.qml:249
> +
> +color: softwareRendering ? undefined : "white"
>  

Is a hardcoded white color always guaranteed to look good even when the album 
art is very light? Is the blurred background always going to be dark enough?

> ExpandedRepresentation.qml:251
>  
> -usesPlasmaTheme: false
> -}
> -}
> +textFormat: Text.PlainText
> +wrapMode: Text.Wrap

I think that's the default, no?

> ExpandedRepresentation.qml:281
> +
> +visible: text !== ""
> +text: {

`text.length !== 0` is a bit faster

> ExpandedRepresentation.qml:332
> +Layout.fillWidth: true
> +Layout.maximumWidth: Math.min(800, 
> expandedRepresentation.width*(7/10))
> +

If the user does something a bit silly like making the applet as big as the 
whole screen, they might prefer if the seek bar is really long

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27160

To: cblack, #vdg, #plasma, manueljlin
Cc: ngraham, manueljlin, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

[Carson Black]

cblack created this revision.
cblack added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  The media controller has been adjusted visually. Note that this is marked as 
WIP due to the fact that the system tray displays margins around the applet, 
which doesn't look too good.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  media-plasmoid-relayout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27160

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml

To: cblack, #vdg, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart