D27271: [kcms/colors] RFC: Accent Colours

[Carson Black]

cblack abandoned this revision.
cblack added a comment.


  https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/305

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27271

To: cblack, #plasma, #vdg
Cc: crossi, ngraham, The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27271: [kcms/colors] RFC: Accent Colours

[Carson Black]

cblack added a comment.


  oooh man, this'll be a doozy to rebase :D

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27271

To: cblack, #plasma, #vdg
Cc: crossi, ngraham, The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27271: [kcms/colors] RFC: Accent Colours

[Carson Black]

cblack added a comment.


  In D27271#676512 , @ngraham wrote:
  
  > Could you move this and the dependent patches to Gitlab? It would be good 
to get this in for 5.21.
  
  
  Sure

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27271

To: cblack, #plasma, #vdg
Cc: crossi, ngraham, The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27271: [kcms/colors] RFC: Accent Colours

[Nathaniel Graham]

ngraham added a comment.


  Could you move this and the dependent patches to Gitlab? It would be good to 
get this in for 5.21.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27271

To: cblack, #plasma, #vdg
Cc: crossi, ngraham, The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27271: [kcms/colors] RFC: Accent Colours

[Cyril Rossi]

crossi added a comment.


  These new properties can be managed by KConfig.
  It will automatically handle the read/write process and 
isSaveNeeded/isDefault status.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27271

To: cblack, #plasma, #vdg
Cc: crossi, ngraham, The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27271: [kcms/colors] RFC: Accent Colours

[Nathaniel Graham]

ngraham added a comment.


  Ping.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27271

To: cblack, #plasma, #vdg
Cc: ngraham, The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27271: [kcms/colors] RFC: Accent Colours

[Nathaniel Graham]

ngraham added a comment.


  Whoops, my bad.
  
  Tested this and found that setting an accept color seems to work for apps and 
Plasma (yay), but unsetting it doesn't go back to the color-scheme-provided one.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27271

To: cblack, #plasma, #vdg
Cc: ngraham, The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27271: [kcms/colors] RFC: Accent Colours

[Carson Black]

cblack added a comment.


  In D27271#643189 , @ngraham wrote:
  
  > This doesn't compile for me:
  >
  >   /home/nate/kde/src/plasma-desktop/kcms/colors/editor/scmeditorcolors.cpp: 
In member function ‘void SchemeEditorColors::updateColorSchemes()’:
  >   
/home/nate/kde/src/plasma-desktop/kcms/colors/editor/scmeditorcolors.cpp:378:16:
 error: ‘class KColorScheme’ has no member named ‘dropAccentColors’
  > 378 | scheme.dropAccentColors();
  > |^~~~
  >
  
  
  You need the patch this patch depends on, D27263 
.
  
  > Also in terms of the UI, I might recommend using radio buttons, sort of 
like this:
  > 
  >   Accent color: (o) Let the active color scheme choose
  > ( ) Custom color: [ color chooser button ]
  > 
  > 
  > This makes the two states clearer IMO. Also it might be good to put 
whatever UI we use below the color scheme chooser grid, since the accent color 
is a subordinate setting.
  
  👍

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27271

To: cblack, #plasma, #vdg
Cc: ngraham, The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27271: [kcms/colors] RFC: Accent Colours

[Nathaniel Graham]

ngraham added a comment.


  This doesn't compile for me:
  
/home/nate/kde/src/plasma-desktop/kcms/colors/editor/scmeditorcolors.cpp: 
In member function ‘void SchemeEditorColors::updateColorSchemes()’:

/home/nate/kde/src/plasma-desktop/kcms/colors/editor/scmeditorcolors.cpp:378:16:
 error: ‘class KColorScheme’ has no member named ‘dropAccentColors’
  378 | scheme.dropAccentColors();
  |^~~~
  
  Also in terms of the UI, I might recommend using radio buttons, sort of like 
this:
  
Accent color: (o) Let the active color scheme choose
  ( ) Custom color: [ color chooser button ]
  
  This makes the two states clearer IMO. Also it might be good to put whatever 
UI we use below the color scheme chooser grid, since the accent color is a 
subordinate setting.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27271

To: cblack, #plasma, #vdg
Cc: ngraham, The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27271: [kcms/colors] RFC: Accent Colours

[Carson Black]

cblack updated this revision to Diff 79513.
cblack added a comment.


  Emit global settings change when accent colour changes

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27271?vs=75318&id=79513

BRANCH
  arcpatch-D27271

REVISION DETAIL
  https://phabricator.kde.org/D27271

AFFECTED FILES
  kcms/colors/colors.cpp
  kcms/colors/colors.h
  kcms/colors/editor/scmeditorcolors.cpp
  kcms/colors/package/contents/ui/main.qml

To: cblack, #plasma, #vdg
Cc: ngraham, The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27271: [kcms/colors] RFC: Accent Colours

[Nathaniel Graham]

ngraham added a comment.


  Looks like plasma doesn't respect the accent color.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27271

To: cblack, #plasma, #vdg
Cc: ngraham, The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27271: [kcms/colors] RFC: Accent Colours

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  Since this is related, I'll just drop my concept design for Colours KCM for 
reference on a possible colour schemes header design to consider. Ignore the 
button at the bottom, I've realised now that that idea is pointless since we 
removed so many colour schemes by now out of the box.
  
  F8095773: Colour Schemes KCM Mockup.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27271

To: cblack, #plasma, #vdg
Cc: The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27271: [kcms/colors] RFC: Accent Colours

[Carson Black]

cblack updated this revision to Diff 75318.
cblack added a comment.


  Use ColorButton

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27271?vs=75317&id=75318

BRANCH
  accent-colors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27271

AFFECTED FILES
  kcms/colors/colors.cpp
  kcms/colors/colors.h
  kcms/colors/editor/scmeditorcolors.cpp
  kcms/colors/package/contents/ui/main.qml

To: cblack, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27271: [kcms/colors] RFC: Accent Colours

[Carson Black]

cblack created this revision.
cblack added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  accent-colors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27271

AFFECTED FILES
  kcms/colors/colors.cpp
  kcms/colors/colors.h
  kcms/colors/editor/scmeditorcolors.cpp
  kcms/colors/package/contents/ui/main.qml

To: cblack, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart