D27362: Linux/cpuinfo.c: grow buffer size as needed for 12+ core CPUs

jakobkummerow added a comment. Thank you! REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D27362 To: jakobkummerow, davidedmundson, ahiemstra Cc: ngraham, ahiemstra, cfeck, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas,

D27362: Linux/cpuinfo.c: grow buffer size as needed for 12+ core CPUs

ahiemstra added a comment. Now pushed with correct author information. :) Thanks! REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D27362 To: jakobkummerow, davidedmundson, ahiemstra Cc: ngraham, ahiemstra, cfeck, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D27362: Linux/cpuinfo.c: grow buffer size as needed for 12+ core CPUs

This revision was automatically updated to reflect the committed changes. Closed by commit R106:7a103a45e349: Linux/cpuinfo.c: grow buffer size as needed for 12+ core CPUs (authored by jakobkummerow, committed by ahiemstra). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE

D27362: Linux/cpuinfo.c: grow buffer size as needed for 12+ core CPUs

ngraham added a comment. One would expect that, yes. But one would be expecting too much of Phabricator. :) REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D27362 To: jakobkummerow, davidedmundson, ahiemstra Cc: ngraham, ahiemstra, cfeck, plasma-devel, Orage,

D27362: Linux/cpuinfo.c: grow buffer size as needed for 12+ core CPUs

jakobkummerow added a comment. Thanks for landing this! My name is Jakob Kummerow, email: jakob.kumme...@gmail.com I created the diff via Phabricator's web interface (uploading a .diff file), would have expected it to take the author information from my account... REPOSITORY R106

D27362: Linux/cpuinfo.c: grow buffer size as needed for 12+ core CPUs

ahiemstra added a comment. @jakobkummerow Ugh, do you have an email address and full name for me? I thought they were in the commit but apparently not (or arc ate them). Then I can fix the authoring information of that commit. REPOSITORY R106 KSysguard REVISION DETAIL

D27362: Linux/cpuinfo.c: grow buffer size as needed for 12+ core CPUs

This revision was automatically updated to reflect the committed changes. Closed by commit R106:62df377051f4: Linux/cpuinfo.c: grow buffer size as needed for 12+ core CPUs (authored by ahiemstra). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE

D27362: Linux/cpuinfo.c: grow buffer size as needed for 12+ core CPUs

jakobkummerow added a comment. ahiemstra: Thanks! I don't have commit access, so I'd appreciate it if you could land this for me. cfeck: Yes, realloc might be a nice improvement (if you think it even matters for this case). Wanna submit a followup PR? REVISION DETAIL

D27362: Linux/cpuinfo.c: grow buffer size as needed for 12+ core CPUs

cfeck added a comment. That looks clever. Since CpuInfoBufSize is a static variable, it will remember the last used size and not reallocate again (unless you plug in new CPUs). Is realloc() an option? It should help the case where the library can actually grow the buffer without an

D27362: Linux/cpuinfo.c: grow buffer size as needed for 12+ core CPUs

ahiemstra accepted this revision. ahiemstra added a comment. This revision is now accepted and ready to land. That's even better, thanks. Do you have commit access? REVISION DETAIL https://phabricator.kde.org/D27362 To: jakobkummerow, davidedmundson, ahiemstra Cc: ahiemstra, cfeck,

D27362: Linux/cpuinfo.c: grow buffer size as needed for 12+ core CPUs

jakobkummerow updated this revision to Diff 75617. jakobkummerow added a comment. Minor update: size_t instead of int. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27362?vs=75616=75617 REVISION DETAIL https://phabricator.kde.org/D27362 AFFECTED FILES

D27362: Linux/cpuinfo.c: grow buffer size as needed for 12+ core CPUs

jakobkummerow updated this revision to Diff 75616. jakobkummerow retitled this revision from "Linux/cpuinfo.c: bump CPUINFOBUFSIZE for 12+ core CPUs" to "Linux/cpuinfo.c: grow buffer size as needed for 12+ core CPUs". jakobkummerow edited the summary of this revision. jakobkummerow added a