D27420: [Applet]Improvements for unavailable port.

This revision was automatically updated to reflect the committed changes. Closed by commit R115:ada3385d04c3: [Applet]Improvements for unavailable port. (authored by gvgeo). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D27420: [Applet]Improvements for unavailable port.

gvgeo added a comment. Don't see anyone objecting, will commit later. REPOSITORY R115 Plasma Audio Volume Applet BRANCH FreeThePort3 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27420 To: gvgeo, #plasma, drosca, ngraham Cc: pino, plasma-devel, Orage, LeGast00n,

D27420: [Applet]Improvements for unavailable port.

gvgeo updated this revision to Diff 75899. gvgeo added a comment. Rebase REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27420?vs=75817=75899 BRANCH FreeThePort3 (branched from master) REVISION DETAIL

D27420: [Applet]Improvements for unavailable port.

ngraham accepted this revision. ngraham added a comment. LGTM. #plasma folks? REPOSITORY R115 Plasma Audio Volume Applet BRANCH freeThePort (branched from master) REVISION DETAIL https://phabricator.kde.org/D27420 To: gvgeo, #plasma, drosca,

D27420: [Applet]Improvements for unavailable port.

gvgeo updated this revision to Diff 75817. gvgeo added a comment. avoid i18n puzzles REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27420?vs=75739=75817 BRANCH freeThePort (branched from master) REVISION DETAIL

D27420: [Applet]Improvements for unavailable port.

ngraham added inline comments. INLINE COMMENTS > gvgeo wrote in ListItemBase.qml:357 > I wanted to do this change, but this is old code from 5.17. I believe that > translated history must exist, and will automatically be used. Better to change it now to avoid the string puzzle entirely IMO

D27420: [Applet]Improvements for unavailable port.

gvgeo added a comment. > ...it solves the reporter's problem... Not exactly. When an available port gets selected(or is active) port option will disappear again. Only enables complete port selection while an unavailable is the default. > Or has the code diverged between 5.18 and

D27420: [Applet]Improvements for unavailable port.

pino added inline comments. INLINE COMMENTS > ListItemBase.qml:357 > +if (port.name == "analog-output-speaker" || > port.name == "analog-input-microphone-internal") { > +menuItem.text += i18nc("Port is > unavailable", "

D27420: [Applet]Improvements for unavailable port.

ngraham added a comment. Or has the code diverged between 5.18 and master too much? REPOSITORY R115 Plasma Audio Volume Applet BRANCH freeThePort (branched from master) REVISION DETAIL https://phabricator.kde.org/D27420 To: gvgeo, #plasma, drosca, ngraham Cc: plasma-devel, Orage,

D27420: [Applet]Improvements for unavailable port.

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. That's a clever fix. Very nice how it solves the reporter's problem without changing the UI at all for everyone else who doesn't need it. No regressions found in testing. What do

D27420: [Applet]Improvements for unavailable port.

gvgeo created this revision. gvgeo added reviewers: Plasma, drosca, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Enable unavailable ports to be active, which was added in 10ab204a62cf