D27426: [KRDB] Rename GTK colours to be exported

[Carson Black]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:fffb352cfa1e: [KRDB] Rename GTK colours to be exported 
(authored by cblack).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27426?vs=75752&id=76185

REVISION DETAIL
  https://phabricator.kde.org/D27426

AFFECTED FILES
  kcms/krdb/krdb.cpp

To: cblack, #plasma, ngraham
Cc: ongunkanat, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27426: [KRDB] Rename GTK colours to be exported

[Ongun Kanat]

ongunkanat added a comment.


  Hi,
  
  I am the reporter of this bug. I saw the e-mail but never had time to comment 
on the issue. It seems it has been approved quite fast. I am glad that it is at 
least possible to modify the style and GTK accepts those changes without hassle.
  
  However I have a suggestion to make it more clear for 3rd party developers. 
The suffix `_breeze` seems like only Breeze-GTK can follow those colors but if 
it works on Breeze-GTK probably other themes can also implement same color 
class names with the `_breeze`. So from a 3rd party GTK theme developer's point 
of view it looks like a Breeze specific feature although they probably can 
implement Plasma compatibility for their own theme too if they want to follow 
KDE's API.
  
  So in my humble opinion using `_plasma` or `_kde_plasma` suffix would be a 
clearer and better indicator for this feature.
  
  Thanks for the effort!

REPOSITORY
  R119 Plasma Desktop

BRANCH
  krdb-rename-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27426

To: cblack, #plasma, ngraham
Cc: ongunkanat, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27426: [KRDB] Rename GTK colours to be exported

[Carson Black]

cblack created this revision.
cblack added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  The colours exported by KRDB for GTK now have the _breeze suffix.

TEST PLAN
  In tandem with D27425 , no visual change 
should be expected.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  krdb-rename-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27426

AFFECTED FILES
  kcms/krdb/krdb.cpp

To: cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart