D27515: Icon: fix rendering of image: urls on High DPI

2020-02-20 Thread Aleix Pol Gonzalez 
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:2c4cc4816c04: Icon: fix rendering of image: urls on High 
DPI (authored by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27515?vs=76034&id=76052

REVISION DETAIL
  https://phabricator.kde.org/D27515

AFFECTED FILES
  src/icon.cpp

To: apol, #plasma, #kirigami, mart, davidedmundson
Cc: davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, mart, hein

D27515: Icon: fix rendering of image: urls on High DPI

2020-02-20 Thread David Edmundson 
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  I was wrong.
  
  QQuickImageBase is the part that has the SVG check.
  
  This is going directly one level lower

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27515

To: apol, #plasma, #kirigami, mart, davidedmundson
Cc: davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, mart, hein

D27515: Icon: fix rendering of image: urls on High DPI

2020-02-20 Thread David Edmundson 
davidedmundson added a comment.


  > QQuickImageProvider wants the requestedSize to be accounting for the dpi 
scaling.
  
  For stupid reasons, that isn't the case if the path is an SVG.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27515

To: apol, #plasma, #kirigami, mart
Cc: davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, mart, hein

D27515: Icon: fix rendering of image: urls on High DPI

2020-02-19 Thread Aleix Pol Gonzalez 
apol created this revision.
apol added reviewers: Plasma, Kirigami, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  QQuickImageProvider wants the requestedSize to be accounting for the dpi
  scaling. We have no information about about the DPI from the implementation
  anyway.
  This is also how it's explained in the qtdeclarative/manual/highdpi/ test in 
Qt.
  
  BUG: 417647

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27515

AFFECTED FILES
  src/icon.cpp

To: apol, #plasma, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein