D27529: [applets/weather] Remove outdated extra configure button

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:2c7737f8fe8d: [applets/weather] Remove outdated extra 
configure button (authored by davidedmundson).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27529?vs=76067&id=76272

REVISION DETAIL
  https://phabricator.kde.org/D27529

AFFECTED FILES
  applets/comic/package/contents/ui/main.qml
  applets/weather/package/contents/ui/FullRepresentation.qml

To: davidedmundson, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27529: [applets/weather] Remove outdated extra configure button

[Nathaniel Graham]

ngraham added a comment.


  And see also D27530 

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27529

To: davidedmundson, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27529: [applets/weather] Remove outdated extra configure button

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Stable branch?

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27529

To: davidedmundson, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27529: [applets/weather] Remove outdated extra configure button

[David Edmundson]

davidedmundson updated this revision to Diff 76067.
davidedmundson added a comment.


  include comics

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27529?vs=76066&id=76067

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27529

AFFECTED FILES
  applets/comic/package/contents/ui/main.qml
  applets/weather/package/contents/ui/FullRepresentation.qml

To: davidedmundson, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27529: [applets/weather] Remove outdated extra configure button

[Nathaniel Graham]

ngraham added a comment.


  Comic strip widget is also affected. If you fix both in this patch, it will 
resolve 412114. :)

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27529

To: davidedmundson, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27529: [applets/weather] Remove outdated extra configure button

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  The containment seems to care for it correctly now
  
  Also the old code was wrong and used anchors on an item inside a layout

TEST PLAN
  New applet with no configuration
  Saw a configure button in the middle still (instead of two)
  Clicking it worked

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27529

AFFECTED FILES
  applets/weather/package/contents/ui/FullRepresentation.qml

To: davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart