D27536: fix(kwayland): remove code with side-effects from Q_ASSERT

2020-02-21 Thread Roman Gilg 
romangg added a comment.


  It would be nice if I get at least 24 hours to review patches in 
KScreen/libkscreen. Thanks for the patch.

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D27536

To: dvratil, #plasma, davidedmundson, meven
Cc: romangg, meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27536: fix(kwayland): remove code with side-effects from Q_ASSERT

2020-02-21 Thread Daniel Vrátil 
This revision was automatically updated to reflect the committed changes.
Closed by commit R110:63cab28e74ee: fix(kwayland): remove code with 
side-effects from Q_ASSERT (authored by dvratil).

REPOSITORY
  R110 KScreen Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27536?vs=76082=76095

REVISION DETAIL
  https://phabricator.kde.org/D27536

AFFECTED FILES
  backends/kwayland/waylandconfig.cpp

To: dvratil, #plasma, davidedmundson, meven
Cc: meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27536: fix(kwayland): remove code with side-effects from Q_ASSERT

2020-02-21 Thread Méven Car 
meven accepted this revision.
meven added a comment.


  Nice !

REPOSITORY
  R110 KScreen Library

BRANCH
  Plasma/5.18

REVISION DETAIL
  https://phabricator.kde.org/D27536

To: dvratil, #plasma, davidedmundson, meven
Cc: meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27536: fix(kwayland): remove code with side-effects from Q_ASSERT

2020-02-21 Thread Daniel Vrátil 
dvratil updated this revision to Diff 76082.
dvratil added a comment.


  - Add bug reference

REPOSITORY
  R110 KScreen Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27536?vs=76080=76082

BRANCH
  Plasma/5.18

REVISION DETAIL
  https://phabricator.kde.org/D27536

AFFECTED FILES
  backends/kwayland/waylandconfig.cpp

To: dvratil, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27536: fix(kwayland): remove code with side-effects from Q_ASSERT

2020-02-20 Thread Daniel Vrátil 
dvratil updated this revision to Diff 76080.
dvratil added a comment.


  - Fix typo

REPOSITORY
  R110 KScreen Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27536?vs=76079=76080

BRANCH
  Plasma/5.18

REVISION DETAIL
  https://phabricator.kde.org/D27536

AFFECTED FILES
  backends/kwayland/waylandconfig.cpp

To: dvratil, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27536: fix(kwayland): remove code with side-effects from Q_ASSERT

2020-02-20 Thread Daniel Vrátil 
dvratil created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
dvratil requested review of this revision.

REPOSITORY
  R110 KScreen Library

BRANCH
  Plasma/5.18

REVISION DETAIL
  https://phabricator.kde.org/D27536

AFFECTED FILES
  backends/kwayland/waylandconfig.cpp

To: dvratil
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart