D27566: WebShortcuts Runner: Refactor foreach, remove unnecessary method
This revision was automatically updated to reflect the committed changes. Closed by commit R120:dceb791c0779: WebShortcuts Runner: Refactor foreach, remove unnecessary method (authored by alex). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27566?vs=78338&id=78339 REVISION DETAIL https://phabricator.kde.org/D27566 AFFECTED FILES runners/webshortcuts/webshortcutrunner.cpp runners/webshortcuts/webshortcutrunner.h To: alex, ngraham, broulik, meven, apol Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27566: WebShortcuts Runner: Refactor foreach, remove unnecessary method
alex updated this revision to Diff 78338.
alex added a comment.
Coding style: put space before {
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27566?vs=76144&id=78338
BRANCH
arcpatch-D27566
REVISION DETAIL
https://phabricator.kde.org/D27566
AFFECTED FILES
runners/webshortcuts/webshortcutrunner.cpp
runners/webshortcuts/webshortcutrunner.h
To: alex, ngraham, broulik, meven, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27566: WebShortcuts Runner: Refactor foreach, remove unnecessary method
broulik accepted this revision.
broulik added inline comments.
INLINE COMMENTS
> webshortcutrunner.cpp:79
> const int delimIndex = term.indexOf(m_delimiter);
> -if (delimIndex == term.length() - 1)
> +if (delimIndex == -1 || delimIndex == term.length() - 1){
> return;
Coding style: put space before `{`
REPOSITORY
R120 Plasma Workspace
BRANCH
webshortcuts_cleanup (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D27566
To: alex, ngraham, broulik, meven, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27566: WebShortcuts Runner: Refactor foreach, remove unnecessary method
alex added a comment. Ping @broulik :-) REPOSITORY R120 Plasma Workspace BRANCH webshortcuts_cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D27566 To: alex, ngraham, broulik, meven, apol Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27566: WebShortcuts Runner: Refactor foreach, remove unnecessary method
meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Seems good to me, wait for @broulik review REPOSITORY R120 Plasma Workspace BRANCH webshortcuts_cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D27566 To: alex, ngraham, broulik, meven, apol Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27566: WebShortcuts Runner: Refactor foreach, remove unnecessary method
alex updated this revision to Diff 76144. alex added a comment. Adjust comment REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27566?vs=76142&id=76144 BRANCH webshortcuts_cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D27566 AFFECTED FILES runners/webshortcuts/webshortcutrunner.cpp runners/webshortcuts/webshortcutrunner.h To: alex, ngraham, broulik, meven, apol Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D27566: WebShortcuts Runner: Refactor foreach, remove unnecessary method
alex created this revision. alex added reviewers: ngraham, broulik, meven, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY The foreach has been refactored and the loadSyntaxes method gets now called directly. Additionally the cached (failed) key/provider can be reused for multiple sessions and is only cleared when the config changes. TEST PLAN Should compile and open urls as before. REPOSITORY R120 Plasma Workspace BRANCH webshortcuts_cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D27566 AFFECTED FILES runners/webshortcuts/webshortcutrunner.cpp runners/webshortcuts/webshortcutrunner.h To: alex, ngraham, broulik, meven, apol Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
