D27577: [KCM]Fix content below scrollbars

2020-03-03 Thread George Vogiatzis
This revision was automatically updated to reflect the committed changes.
Closed by commit R115:552b0384ffd2: [KCM]Fix content below scrollbars (authored 
by gvgeo).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27577?vs=76467=76836

REVISION DETAIL
  https://phabricator.kde.org/D27577

AFFECTED FILES
  src/kcm/package/contents/ui/Advanced.qml
  src/kcm/package/contents/ui/Applications.qml
  src/kcm/package/contents/ui/Devices.qml
  src/kcm/package/contents/ui/Header.qml
  src/kcm/package/contents/ui/main.qml

To: gvgeo, #plasma, #vdg, drosca, ngraham
Cc: ngraham, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart


D27577: [KCM]Fix content below scrollbars

2020-02-29 Thread Nathaniel Graham
ngraham added a comment.


  +1, go ahead

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  advanced2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27577

To: gvgeo, #plasma, #vdg, drosca, ngraham
Cc: ngraham, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart


D27577: [KCM]Fix content below scrollbars

2020-02-28 Thread George Vogiatzis
gvgeo added a comment.


  I don't see any objections, will push to stable.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  advanced2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27577

To: gvgeo, #plasma, #vdg, drosca, ngraham
Cc: ngraham, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart


D27577: [KCM]Fix content below scrollbars

2020-02-26 Thread George Vogiatzis
gvgeo updated this revision to Diff 76467.
gvgeo added a comment.


  Added item as a proxy for the devices and applications. This fixed the 
vertical binding loop.
  And made scrollbar touch the top and botoom edges.
  
  With this patch content is closer, by smallSpacing, to the frame.
  And content touch top and bottom when scrolling.

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27577?vs=76202=76467

BRANCH
  advanced2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27577

AFFECTED FILES
  src/kcm/package/contents/ui/Advanced.qml
  src/kcm/package/contents/ui/Applications.qml
  src/kcm/package/contents/ui/Devices.qml
  src/kcm/package/contents/ui/Header.qml
  src/kcm/package/contents/ui/main.qml

To: gvgeo, #plasma, #vdg, drosca, ngraham
Cc: ngraham, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart


D27577: [KCM]Fix content below scrollbars

2020-02-24 Thread Nathaniel Graham
ngraham added a comment.


  We can wait a bit to get more eyes on it and target 5.18.3.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  advanced2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27577

To: gvgeo, #plasma, #vdg, drosca, ngraham
Cc: ngraham, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart


D27577: [KCM]Fix content below scrollbars

2020-02-24 Thread George Vogiatzis
gvgeo added a comment.


  Today for 5.18.2 or can wait?
  Apol only looked the code for the first change.
  And I don't know why vertical margins create bind loop, or if Item as a proxy 
is good.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  advanced2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27577

To: gvgeo, #plasma, #vdg, drosca, ngraham
Cc: ngraham, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart


D27577: [KCM]Fix content below scrollbars

2020-02-24 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  In D27577#616919 , @gvgeo wrote:
  
  > > The other change to center labels
  >
  > They were already centered.
  
  
  Oops, my bad.
  
  Seems like material for the stable branch. Have you gotten your developer 
account approved yet?
  
  
https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  advanced2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27577

To: gvgeo, #plasma, #vdg, drosca, ngraham
Cc: ngraham, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart


D27577: [KCM]Fix content below scrollbars

2020-02-24 Thread George Vogiatzis
gvgeo added a comment.


  I would not call them stylistic choice, the position didn't change. And there 
are included in description.
  
Make Header always fit inside the scrollview area.
  
  They had 2 different problems, when the text is too big.
  As enabled they would cut text left and right.
  And as disabled would make the page wide with vertical scrollbar.
  And If I remember  correctly, would display under the scrollbar.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27577

To: gvgeo, #plasma, #vdg, drosca
Cc: ngraham, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart


D27577: [KCM]Fix content below scrollbars

2020-02-24 Thread Nathaniel Graham
ngraham added a comment.


  As far as I can tell, the other four changes are related to the 
scrollbar/view sizing/positioning. The other change to center labels may fix an 
issue, but it still represents a stylistic change. It should either be in a 
separate patch, or else it needs to be explicitly explained in the Summary 
and/or Description section.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27577

To: gvgeo, #plasma, #vdg, drosca
Cc: ngraham, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart


D27577: [KCM]Fix content below scrollbars

2020-02-23 Thread George Vogiatzis
gvgeo added a comment.


  In D27577#616579 , @ngraham wrote:
  
  > The changes to labels in `Header.qml` seem unrelated.
  
  
  They are as related as the other 4 changes are.
  Either will make 5 different patches or 1. But I'm not going to change back 
and forth.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27577

To: gvgeo, #plasma, #vdg, drosca
Cc: ngraham, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart


D27577: [KCM]Fix content below scrollbars

2020-02-23 Thread Nathaniel Graham
ngraham added a comment.


  The changes to labels in `Header.qml` seem unrelated.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27577

To: gvgeo, #plasma, #vdg, drosca
Cc: ngraham, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart


D27577: [KCM]Fix content below scrollbars

2020-02-23 Thread George Vogiatzis
gvgeo updated this revision to Diff 76202.
gvgeo added a comment.


  typo

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27577?vs=76201=76202

BRANCH
  advanced2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27577

AFFECTED FILES
  src/kcm/package/contents/ui/Advanced.qml
  src/kcm/package/contents/ui/Applications.qml
  src/kcm/package/contents/ui/Devices.qml
  src/kcm/package/contents/ui/Header.qml
  src/kcm/package/contents/ui/main.qml

To: gvgeo, #plasma, #vdg, drosca
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart


D27577: [KCM]Fix content below scrollbars

2020-02-23 Thread George Vogiatzis
gvgeo updated this revision to Diff 76201.
gvgeo added a comment.


  Make scrollbars touch the side of the frame.
  Fit speaker test grid inside the scrollview area.
  Fix advanced content layout.
  Make Header always fit inside the scrollview area.

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27577?vs=76200=76201

BRANCH
  advanced2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27577

AFFECTED FILES
  src/kcm/package/contents/ui/Advanced.qml
  src/kcm/package/contents/ui/Applications.qml
  src/kcm/package/contents/ui/Devices.qml
  src/kcm/package/contents/ui/Header.qml
  src/kcm/package/contents/ui/main.qml

To: gvgeo, #plasma, #vdg, drosca
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart


D27577: [KCM]Fix content below scrollbars

2020-02-22 Thread George Vogiatzis
gvgeo updated this revision to Diff 76200.
gvgeo edited the test plan for this revision.
gvgeo added a comment.


  Changed comment.

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27577?vs=76173=76200

BRANCH
  scrollbars (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27577

AFFECTED FILES
  src/kcm/package/contents/ui/Advanced.qml
  src/kcm/package/contents/ui/Applications.qml
  src/kcm/package/contents/ui/Devices.qml

To: gvgeo, #plasma, #vdg, drosca
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart


D27577: [KCM]Fix content below scrollbars

2020-02-22 Thread George Vogiatzis
gvgeo added inline comments.

INLINE COMMENTS

> Advanced.qml:33
> +// TODO Fix contentview width, and Remove policy.
> +ScrollBar.horizontal.policy: ScrollBar.AlwaysOff
>  

> What if there's too many devices?

No matter how many devices there are, column is always a column.

> It doesn't sound like a good solution to hide the ScrollBar forever.

That's why a TODO comment exist.

> Also what does contentview refer to?

The width of the content. Need to remove "view".

ContentWidth calculates most of the text with contentWidth instead of 
paintedWidth.
Have not found the loop.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27577

To: gvgeo, #plasma, #vdg, drosca
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart


D27577: [KCM]Fix content below scrollbars

2020-02-22 Thread Aleix Pol Gonzalez
apol added inline comments.

INLINE COMMENTS

> Advanced.qml:33
> +// TODO Fix contentview width, and Remove policy.
> +ScrollBar.horizontal.policy: ScrollBar.AlwaysOff
>  

What if there's too many devices?
It doesn't sound like a good solution to hide the ScrollBar forever.

Also what does contentview refer to?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27577

To: gvgeo, #plasma, #vdg, drosca
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart


D27577: [KCM]Fix content below scrollbars

2020-02-22 Thread George Vogiatzis
gvgeo created this revision.
gvgeo added reviewers: Plasma, VDG, drosca.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gvgeo requested review of this revision.

REVISION SUMMARY
  Set content to use available space.
  
  BUG:416331
  BUG:417447

TEST PLAN
  Open audio settings from kickoff.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  scrollbars (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27577

AFFECTED FILES
  src/kcm/package/contents/ui/Advanced.qml
  src/kcm/package/contents/ui/Applications.qml
  src/kcm/package/contents/ui/Devices.qml

To: gvgeo, #plasma, #vdg, drosca
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart