D27675: feat: avoid duplicated text when assembling user-facing output names

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. Sorry for late review. I didn't get notified by this bullshit platform (which might be because I disabled all notifications at one point to not get spammed constantly). INLINE COMMENTS

D27675: feat: avoid duplicated text when assembling user-facing output names

dvratil updated this revision to Diff 77838. dvratil added a comment. - Simplify a bit more REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27675?vs=77837=77838 BRANCH arcpatch-D27675 REVISION DETAIL https://phabricator.kde.org/D27675 AFFECTED FILES

D27675: feat: avoid duplicated text when assembling user-facing output names

dvratil updated this revision to Diff 77837. dvratil added a comment. - Make the lambda more explicit - Address review comments REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27675?vs=76457=77837 BRANCH arcpatch-D27675 REVISION DETAIL

D27675: feat: avoid duplicated text when assembling user-facing output names

romangg added a comment. In D27675#629182 , @dvratil wrote: > As you described, the system makes sense on X11 where you get something like `HDMI-1 (Sony GigaTV-12345)` so you see which device it is and what physical output it's connected to.

D27675: feat: avoid duplicated text when assembling user-facing output names

dvratil added a comment. The system makes sense on X11 where you get something like `HDMI-1 (Sony GigaTV-12345)` so you see which device it is and what physical output it's connected to. Since KWin does not use to output names but only the names of the actually connected devices, the needed

D27675: feat: avoid duplicated text when assembling user-facing output names

ahmadsamir added inline comments. INLINE COMMENTS > utils.cpp:64 > +return append(name, QLatin1Char('(') + output->name() + > QLatin1Char(')')); > } > } If I am reading this correctly, you could keep the old code and use simplified(): const QString outName =

D27675: feat: avoid duplicated text when assembling user-facing output names

romangg requested changes to this revision. romangg added a comment. This revision now requires changes to proceed. Ok, I see the issue. The question is if `Vendor Model` is not a bit stupid as a name for an output and if KWin/KWayland should not be a bit more intelligent about choosing a

D27675: feat: avoid duplicated text when assembling user-facing output names

romangg added a reviewer: romangg. romangg added a comment. I am currently working on some projects. But if you don't hear till Sunday from me about this, ping me. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D27675 To: dvratil, #plasma, romangg Cc: romangg,

D27675: feat: avoid duplicated text when assembling user-facing output names

dvratil added a comment. This is needed for D10042 (which I'm rebasing right now) when even on KWayland the `KScreen::Output` will have EDID attached (assembled from information provided by KWayland/KWin). Since on KWayland the output name already is

D27675: feat: Avoid duplicated text when assembling user-facing output names

romangg added a comment. Can you give an example? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D27675 To: dvratil, #plasma Cc: romangg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham,

D27675: feat: Avoid duplicated text when assembling user-facing output names

dvratil created this revision. dvratil added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dvratil requested review of this revision. REVISION SUMMARY The string format by default is `Vendor Model (output)`, where `Vendor` and `Model` are read