D27711: [Applet]Use gridLayout for details

gvgeo added a comment. Instead of kuserfeedback which uploads data collected prior users consent, I believe this patch is good enough. @ngraham It appears that I should let you know that, I'm no longer going to work on it under these circumstances, so that you can use it if you want.

D27711: [Applet]Use gridLayout for details

gvgeo added a comment. Generally FormLayout is unfit for this, If I understand it correctly they cannot get `theme.smallestFont` height. Which will introduce big height, and big margins between lines. > IIRC the labels were reduced opacity before, and this was not a change introduced

D27711: [Applet]Use gridLayout for details

ngraham added a subscriber: manueljlin. ngraham added a comment. FormLayouts are used all over the place. But typically, we don't reduce the opacity of the labels. I'm not categorically against it, I'm just wondering. IIRC the labels were reduced opacity before, and this was not a change

D27711: [Applet]Use gridLayout for details

gvgeo added a comment. > Do we need to reduce the opacity for the labels? Is this a visual design argument or a coding one? The opacity was reduced in the layout update. Are you saying that should not had be changed. IMO this is vital part of the new layout. > We don't really do

D27711: [Applet]Use gridLayout for details

ngraham added a comment. Do we need to reduce the opacity for the labels? We don't really do this anywhere else. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27711 To: gvgeo, #plasma, jgrulich, ngraham Cc: plasma-devel, Orage, LeGast00n,

D27711: [Applet]Use gridLayout for details

gvgeo added a comment. @ngraham If FormLayout does not support opacity/enabled for labels, then maybe, this patch is good enough. INLINE COMMENTS > DetailsText.qml:67 > font.pointSize: theme.smallestFont.pointSize > -text: details[(index*2)+1] > +

D27711: [Applet]Use gridLayout for details

gvgeo abandoned this revision. gvgeo added a comment. In favor of kirigami form. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27711 To: gvgeo, #plasma, jgrulich, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D27711: [Applet]Use gridLayout for details

ngraham added a comment. Yeah, that's fine. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27711 To: gvgeo, #plasma, jgrulich, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D27711: [Applet]Use gridLayout for details

gvgeo added a comment. Kirigami in applet? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27711 To: gvgeo, #plasma, jgrulich, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D27711: [Applet]Use gridLayout for details

ngraham added a comment. Even better than a GridLayout is a `Kirigami.FormLayout! That's what's being approximated here, so why not use the real thing? :) REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27711 To: gvgeo, #plasma, jgrulich,

D27711: [Applet]Use gridLayout for details

gvgeo added a comment. Separate patch so can be easily reverted, if a grid+repeater problem exist R120:d12521b149fa . REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL

D27711: [Applet]Use gridLayout for details

gvgeo created this revision. gvgeo added reviewers: Plasma, jgrulich, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Use gridLayout for repeater in DetailsText. Now right mouse menu(copy) opens on