D27785: [Fonts KCM] Change how nearestExistingFonts() finds a matching font

[Ahmad Samir]

ahmadsamir abandoned this revision.
ahmadsamir added a comment.


  Not needed with D27808 , which will use 
KFontChooserDialog everywhere.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27785

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven, bport
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27785: [Fonts KCM] Change how nearestExistingFonts() finds a matching font

[Ahmad Samir]

ahmadsamir added a comment.


  In D27785#628110 , @bport wrote:
  
  > Ok for me but need to wait approval on font dialog review (to ensure 
correct font style is selected when editing)
  
  
  Thanks.
  
  The font dialog review, D27808 , took a 
different turn..., see https://phabricator.kde.org/D27808#625255 for details.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D27785 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27785

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven, bport
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27785: [Fonts KCM] Change how nearestExistingFonts() finds a matching font

[Benjamin Port]

bport accepted this revision.
bport added a comment.
This revision is now accepted and ready to land.


  Ok for me but need to wait approval on font dialog review (to ensure correct 
font style is selected when editing)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D27785 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27785

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven, bport
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27785: [Fonts KCM] Change how nearestExistingFonts() finds a matching font

[Ahmad Samir]

ahmadsamir updated this revision to Diff 77442.
ahmadsamir retitled this revision from "[Fonts KCM] Change 
setNearestExistingFonts() to set the fonts only when necessary" to "[Fonts KCM] 
Change how nearestExistingFonts() finds a matching font".
ahmadsamir edited the summary of this revision.
ahmadsamir removed a subscriber: bport.
ahmadsamir added a comment.


  Rebase
  Actually address comments

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27785?vs=77268&id=77442

BRANCH
  arcpatch-D27785 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27785

AFFECTED FILES
  kcms/fonts/fonts.cpp

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart, bport

D27785: [Fonts KCM] Change how nearestExistingFonts() finds a matching font

[Ahmad Samir]

ahmadsamir updated this revision to Diff 77265.
ahmadsamir edited the summary of this revision.
ahmadsamir added a comment.


  Tweak commit message

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27785?vs=77264&id=77265

BRANCH
  arcpatch-D27785 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27785

AFFECTED FILES
  kcms/fonts/fonts.cpp

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27785: [Fonts KCM] Change how nearestExistingFonts() finds a matching font

[Ahmad Samir]

ahmadsamir updated this revision to Diff 77264.
ahmadsamir marked 3 inline comments as done.
ahmadsamir retitled this revision from "[Fonts KCM] Change 
setNearestExistingFonts() to set the fonts only when necessary" to "[Fonts KCM] 
Change how nearestExistingFonts() finds a matching font".
ahmadsamir edited the summary of this revision.
ahmadsamir added a comment.


  Address comments

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27785?vs=77258&id=77264

BRANCH
  arcpatch-D27785 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27785

AFFECTED FILES
  kcms/fonts/fonts.cpp

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart