D27792: [Applet]Fix traffic monitor labels width

This revision was automatically updated to reflect the committed changes. Closed by commit R116:986341a3fae8: [Applet]Fix traffic monitor labels width (authored by gvgeo). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D27792: [Applet]Fix traffic monitor labels width

ngraham added a comment. Yeah, if you want to keep the plotter dimensions constant, then there's no way around measuring the width of the labels. Regarding not opening any new patches, I hope you didn't have a bad experience in KDE that's left a bad taste in your mouth. If anything's

D27792: [Applet]Fix traffic monitor labels width

gvgeo added a comment. I don't plan to make more patches, for now. But if the problem would not exist with layouts, prefer to do it than make quick bugfixes. But can't see how the Layouts would help with that. Everything can be done without Layouts too AFAIK, just more messy. I want

D27792: [Applet]Fix traffic monitor labels width

ngraham accepted this revision. ngraham added a comment. If you need to measure the width of text, then you're doing it the right way. However this problem wouldn't be happening in the first place if this UI used Layouts, which handle this kind of case more elegantly so you don't need to

D27792: [Applet]Fix traffic monitor labels width

gvgeo added a comment. #VDG Does a better way exist, to measure the width of transfer speed text? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D27792 To: gvgeo, #vdg, #plasma, jgrulich, ngraham Cc:

D27792: [Applet]Fix traffic monitor labels width

gvgeo added a comment. Is it? INLINE COMMENTS > TrafficMonitor.qml:107 > +// Measure 888.8 KiB/s > +text: KCoreAddons.Format.formatByteSize(910131) + i18n("/s") > +} Biggest number it can display? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL

D27792: [Applet]Fix traffic monitor labels width

davidedmundson added inline comments. INLINE COMMENTS > TrafficMonitor.qml:107 > +// Measure 888.8 KiB/s > +text: KCoreAddons.Format.formatByteSize(910131) + i18n("/s") > +} what is this number about? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL

D27792: [Applet]Fix traffic monitor labels width

gvgeo added a comment. @ngraham Is there a better way to fix this? In D27199#620730 , @jgrulich wrote: > Looks this changed introduced an issue. The traffic monitor doesn't fit into the applet. > > See picture below: > F8145280:

D27792: [Applet]Fix traffic monitor labels width

gvgeo created this revision. gvgeo added reviewers: VDG, Plasma, jgrulich, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REVISION SUMMARY Use text metrics to set a proper space for labels. And remove unused plotter