D27823: Use consistent highlight

2020-03-10 Thread George Vogiatzis 
gvgeo added a comment.


  Couple of notes, as I'm not sure what the aim was here. I have not test it, 
take them with a grain of salt.
  
  - Highlight area was changed, without changing the click area.
  - Connect button pop up area change, was not documented.
  - Highlight svg is not consistent with list's highlight. And maybe not always 
look good. (Although it's designation is pressed, everywhere used as highlight, 
which is an different story itself.)
  - There is code left in various places, listitem.qml possibly could be 
removed completely now.
  
  ---
  
  The line above, is because you did not build plasma-nm but instead copied the 
qml files.
  See T10470  for the icon size.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27823

To: niccolove, jgrulich, #vdg, ngraham
Cc: gvgeo, davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

2020-03-09 Thread Niccolò Venerandi 
This revision was automatically updated to reflect the committed changes.
Closed by commit R116:b7291760dce1: Use consistent highlight (authored by 
niccolove).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27823?vs=77254&id=77310

REVISION DETAIL
  https://phabricator.kde.org/D27823

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/PopupDialog.qml

To: niccolove, jgrulich, #vdg, ngraham
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

2020-03-09 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.


  Thanks, everything works now. :)
  
  I don't see that extra line in mine. But yeah, if it's reproducible, it's a 
bug that should be fixed.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27823

To: niccolove, jgrulich, #vdg, ngraham
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

2020-03-09 Thread Niccolò Venerandi 
niccolove added a comment.


  Sorry, I had different files with different versions. Now it shows correctly 
for me, with all files up to date. That said, is it normal that:
  F8167163: image.png 
  
  - the top elements has a top separator
  - icon size of the second element is smaller
  
  ? seems wrong to me, but not because of this patch

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27823

To: niccolove, jgrulich, #vdg, ngraham
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

2020-03-09 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 77254.
niccolove added a comment.


  ops

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27823?vs=77253&id=77254

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27823

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/PopupDialog.qml

To: niccolove, jgrulich, #vdg, ngraham
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

2020-03-09 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 77253.
niccolove added a comment.


  fixed name of list

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27823?vs=77219&id=77253

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27823

AFFECTED FILES
  CMakeLists.txt
  applet/contents/config/config.qml
  applet/contents/config/main.xml
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/DetailsText.qml
  applet/contents/ui/Header.qml
  applet/contents/ui/ListItem.qml
  applet/contents/ui/PasswordField.qml
  applet/contents/ui/PopupDialog.qml
  applet/contents/ui/SwitchButton.qml
  applet/contents/ui/Toolbar.qml
  applet/contents/ui/TrafficMonitor.qml
  applet/contents/ui/configGeneral.qml
  applet/contents/ui/main.qml
  applet/metadata.desktop
  kcm/CMakeLists.txt
  kcm/kcm.cpp
  kcm/kcm_networkmanagement.desktop
  kcm/qml/AddConnectionDialog.qml
  kcm/qml/ConfigurationDialog.qml
  kcm/qml/ConnectionItem.qml
  kcm/qml/Dialog.qml
  kcm/qml/main.qml
  kded/modemmonitor.cpp
  kded/networkmanagement.desktop
  kded/networkmanagement.notifyrc
  kded/notification.cpp
  kded/portalmonitor.cpp
  kded/portalmonitor.h
  kded/service.cpp
  libs/configuration.cpp
  libs/configuration.h
  libs/declarative/enabledconnections.h
  libs/declarative/enums.h
  libs/editor/connectioneditorbase.cpp
  libs/editor/settings/bondwidget.cpp
  libs/editor/settings/connectionwidget.cpp
  libs/editor/settings/ipv4widget.cpp
  libs/editor/settings/ipv6widget.cpp
  libs/editor/settings/security802-1x.cpp
  libs/editor/settings/ui/wifisecurity.ui
  libs/editor/settings/ui/wiredconnectionwidget.ui
  libs/editor/settings/vlanwidget.cpp
  libs/editor/settings/wificonnectionwidget.cpp
  libs/editor/settings/wifisecurity.cpp
  libs/editor/settings/wifisecurity.h
  libs/editor/settings/wiredconnectionwidget.cpp
  libs/editor/settings/wiredconnectionwidget.h
  libs/editor/settings/wireguardpeerwidget.cpp
  libs/editor/widgets/passwordfield.cpp
  libs/editor/widgets/settingwidget.cpp
  libs/handler.cpp
  libs/handler.h
  libs/models/networkmodel.cpp
  libs/models/networkmodel.h
  libs/models/networkmodelitem.cpp
  libs/uiutils.cpp
  mobile/broadband/mobilebroadbandsettings.desktop
  mobile/broadband/package/metadata.desktop
  mobile/wifi/package/contents/ui/PasswordField.qml
  mobile/wifi/package/metadata.desktop
  mobile/wifi/wifisettings.desktop
  vpn/fortisslvpn/fortisslvpnwidget.cpp
  vpn/l2tp/CMakeLists.txt
  vpn/l2tp/l2tp.cpp
  vpn/l2tp/l2tp.ui
  vpn/l2tp/l2tpadvanced.ui
  vpn/l2tp/l2tpadvancedwidget.cpp
  vpn/l2tp/l2tpadvancedwidget.h
  vpn/l2tp/l2tpauth.cpp
  vpn/l2tp/l2tpauth.h
  vpn/l2tp/l2tpauth.ui
  vpn/l2tp/l2tpipsec.ui
  vpn/l2tp/l2tpipsecwidget.cpp
  vpn/l2tp/l2tpipsecwidget.h
  vpn/l2tp/l2twidget.cpp
  vpn/l2tp/l2twidget.h
  vpn/l2tp/l2tpwidget.cpp
  vpn/l2tp/l2tpwidget.h
  vpn/l2tp/nm-l2tp-service.h
  vpn/openconnect/CMakeLists.txt
  vpn/openconnect/openconnectauth.cpp
  vpn/openconnect/openconnectauthworkerthread.cpp
  vpn/openconnect/openconnectwidget.cpp
  vpn/openconnect/plasmanetworkmanagement_openconnect_globalprotectui.desktop
  vpn/openvpn/openvpnadvancedwidget.cpp
  vpn/ssh/plasmanetworkmanagement_sshui.desktop
  vpn/ssh/sshwidget.cpp

To: niccolove, jgrulich, #vdg, ngraham
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

2020-03-08 Thread Nathaniel Graham 
ngraham added a comment.


  Now I see no highlight effect at all.
  
  Does this work for you?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27823

To: niccolove, jgrulich, #vdg, ngraham
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

2020-03-08 Thread Niccolò Venerandi 
niccolove added a comment.


  Should now work?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27823

To: niccolove, jgrulich, #vdg, ngraham
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

2020-03-08 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 77219.
niccolove added a comment.


  remove old highlight

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27823?vs=77218&id=77219

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27823

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/PopupDialog.qml

To: niccolove, jgrulich, #vdg, ngraham
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

2020-03-08 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 77217.
niccolove added a comment.


  remove old highlight

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27823?vs=77215&id=77217

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27823

AFFECTED FILES
  CMakeLists.txt
  applet/contents/config/config.qml
  applet/contents/config/main.xml
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/DetailsText.qml
  applet/contents/ui/Header.qml
  applet/contents/ui/ListItem.qml
  applet/contents/ui/PasswordField.qml
  applet/contents/ui/PopupDialog.qml
  applet/contents/ui/SwitchButton.qml
  applet/contents/ui/Toolbar.qml
  applet/contents/ui/TrafficMonitor.qml
  applet/contents/ui/configGeneral.qml
  applet/contents/ui/main.qml
  applet/metadata.desktop
  kcm/CMakeLists.txt
  kcm/kcm.cpp
  kcm/kcm_networkmanagement.desktop
  kcm/qml/AddConnectionDialog.qml
  kcm/qml/ConfigurationDialog.qml
  kcm/qml/ConnectionItem.qml
  kcm/qml/Dialog.qml
  kcm/qml/main.qml
  kded/modemmonitor.cpp
  kded/networkmanagement.desktop
  kded/networkmanagement.notifyrc
  kded/notification.cpp
  kded/portalmonitor.cpp
  kded/portalmonitor.h
  kded/service.cpp
  libs/configuration.cpp
  libs/configuration.h
  libs/declarative/enabledconnections.h
  libs/declarative/enums.h
  libs/editor/connectioneditorbase.cpp
  libs/editor/settings/bondwidget.cpp
  libs/editor/settings/connectionwidget.cpp
  libs/editor/settings/ipv4widget.cpp
  libs/editor/settings/ipv6widget.cpp
  libs/editor/settings/security802-1x.cpp
  libs/editor/settings/ui/wifisecurity.ui
  libs/editor/settings/ui/wiredconnectionwidget.ui
  libs/editor/settings/vlanwidget.cpp
  libs/editor/settings/wificonnectionwidget.cpp
  libs/editor/settings/wifisecurity.cpp
  libs/editor/settings/wifisecurity.h
  libs/editor/settings/wiredconnectionwidget.cpp
  libs/editor/settings/wiredconnectionwidget.h
  libs/editor/settings/wireguardpeerwidget.cpp
  libs/editor/widgets/passwordfield.cpp
  libs/editor/widgets/settingwidget.cpp
  libs/handler.cpp
  libs/handler.h
  libs/models/networkmodel.cpp
  libs/models/networkmodel.h
  libs/models/networkmodelitem.cpp
  libs/uiutils.cpp
  mobile/broadband/mobilebroadbandsettings.desktop
  mobile/broadband/package/metadata.desktop
  mobile/wifi/package/contents/ui/PasswordField.qml
  mobile/wifi/package/metadata.desktop
  mobile/wifi/wifisettings.desktop
  vpn/fortisslvpn/fortisslvpnwidget.cpp
  vpn/l2tp/CMakeLists.txt
  vpn/l2tp/l2tp.cpp
  vpn/l2tp/l2tp.ui
  vpn/l2tp/l2tpadvanced.ui
  vpn/l2tp/l2tpadvancedwidget.cpp
  vpn/l2tp/l2tpadvancedwidget.h
  vpn/l2tp/l2tpauth.cpp
  vpn/l2tp/l2tpauth.h
  vpn/l2tp/l2tpauth.ui
  vpn/l2tp/l2tpipsec.ui
  vpn/l2tp/l2tpipsecwidget.cpp
  vpn/l2tp/l2tpipsecwidget.h
  vpn/l2tp/l2twidget.cpp
  vpn/l2tp/l2twidget.h
  vpn/l2tp/l2tpwidget.cpp
  vpn/l2tp/l2tpwidget.h
  vpn/l2tp/nm-l2tp-service.h
  vpn/openconnect/CMakeLists.txt
  vpn/openconnect/openconnectauth.cpp
  vpn/openconnect/openconnectauthworkerthread.cpp
  vpn/openconnect/openconnectwidget.cpp
  vpn/openconnect/plasmanetworkmanagement_openconnect_globalprotectui.desktop
  vpn/openvpn/openvpnadvancedwidget.cpp
  vpn/ssh/plasmanetworkmanagement_sshui.desktop
  vpn/ssh/sshwidget.cpp

To: niccolove, jgrulich, #vdg, ngraham
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

2020-03-08 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 77218.
niccolove added a comment.


  ops

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27823?vs=77217&id=77218

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27823

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/PopupDialog.qml

To: niccolove, jgrulich, #vdg, ngraham
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

2020-03-08 Thread Nathaniel Graham 
ngraham added a comment.


  Does this work for you? I still see the old highlight.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27823

To: niccolove, jgrulich, #vdg, ngraham
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

2020-03-08 Thread Nathaniel Graham 
ngraham added a comment.


  There we go, much better now. :) Reviewing...

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27823

To: niccolove, jgrulich, #vdg, ngraham
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

2020-03-08 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 77215.
niccolove added a comment.


  rebase x3

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27823?vs=77214&id=77215

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27823

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/PopupDialog.qml

To: niccolove, jgrulich, #vdg, ngraham
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

2020-03-08 Thread David Redondo 
davidre added a comment.


  Probably your arc diff base target thingy didn't switch and is on the old 
commit so this includes everything new on the master branch. Specify it 
manually with `arc diff master` or `arc diff origin/master`

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27823

To: niccolove, jgrulich, #vdg, ngraham
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

2020-03-08 Thread Niccolò Venerandi 
niccolove added a comment.


  well fuck.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27823

To: niccolove, jgrulich, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

2020-03-08 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 77214.
niccolove added a comment.


  rebase x2

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27823?vs=77212&id=77214

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27823

AFFECTED FILES
  CMakeLists.txt
  applet/contents/config/config.qml
  applet/contents/config/main.xml
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/DetailsText.qml
  applet/contents/ui/Header.qml
  applet/contents/ui/ListItem.qml
  applet/contents/ui/PasswordField.qml
  applet/contents/ui/PopupDialog.qml
  applet/contents/ui/SwitchButton.qml
  applet/contents/ui/Toolbar.qml
  applet/contents/ui/TrafficMonitor.qml
  applet/contents/ui/configGeneral.qml
  applet/contents/ui/main.qml
  applet/metadata.desktop
  kcm/CMakeLists.txt
  kcm/kcm.cpp
  kcm/kcm_networkmanagement.desktop
  kcm/qml/AddConnectionDialog.qml
  kcm/qml/ConfigurationDialog.qml
  kcm/qml/ConnectionItem.qml
  kcm/qml/Dialog.qml
  kcm/qml/main.qml
  kded/modemmonitor.cpp
  kded/networkmanagement.desktop
  kded/networkmanagement.notifyrc
  kded/notification.cpp
  kded/portalmonitor.cpp
  kded/portalmonitor.h
  kded/service.cpp
  libs/configuration.cpp
  libs/configuration.h
  libs/declarative/enabledconnections.h
  libs/declarative/enums.h
  libs/editor/connectioneditorbase.cpp
  libs/editor/settings/bondwidget.cpp
  libs/editor/settings/connectionwidget.cpp
  libs/editor/settings/ipv4widget.cpp
  libs/editor/settings/ipv6widget.cpp
  libs/editor/settings/security802-1x.cpp
  libs/editor/settings/ui/wifisecurity.ui
  libs/editor/settings/ui/wiredconnectionwidget.ui
  libs/editor/settings/vlanwidget.cpp
  libs/editor/settings/wificonnectionwidget.cpp
  libs/editor/settings/wifisecurity.cpp
  libs/editor/settings/wifisecurity.h
  libs/editor/settings/wiredconnectionwidget.cpp
  libs/editor/settings/wiredconnectionwidget.h
  libs/editor/settings/wireguardpeerwidget.cpp
  libs/editor/widgets/passwordfield.cpp
  libs/editor/widgets/settingwidget.cpp
  libs/handler.cpp
  libs/handler.h
  libs/models/networkmodel.cpp
  libs/models/networkmodel.h
  libs/models/networkmodelitem.cpp
  libs/uiutils.cpp
  mobile/broadband/mobilebroadbandsettings.desktop
  mobile/broadband/package/metadata.desktop
  mobile/wifi/package/contents/ui/PasswordField.qml
  mobile/wifi/package/metadata.desktop
  mobile/wifi/wifisettings.desktop
  vpn/fortisslvpn/fortisslvpnwidget.cpp
  vpn/l2tp/CMakeLists.txt
  vpn/l2tp/l2tp.cpp
  vpn/l2tp/l2tp.ui
  vpn/l2tp/l2tpadvanced.ui
  vpn/l2tp/l2tpadvancedwidget.cpp
  vpn/l2tp/l2tpadvancedwidget.h
  vpn/l2tp/l2tpauth.cpp
  vpn/l2tp/l2tpauth.h
  vpn/l2tp/l2tpauth.ui
  vpn/l2tp/l2tpipsec.ui
  vpn/l2tp/l2tpipsecwidget.cpp
  vpn/l2tp/l2tpipsecwidget.h
  vpn/l2tp/l2twidget.cpp
  vpn/l2tp/l2twidget.h
  vpn/l2tp/l2tpwidget.cpp
  vpn/l2tp/l2tpwidget.h
  vpn/l2tp/nm-l2tp-service.h
  vpn/openconnect/CMakeLists.txt
  vpn/openconnect/openconnectauth.cpp
  vpn/openconnect/openconnectauthworkerthread.cpp
  vpn/openconnect/openconnectwidget.cpp
  vpn/openconnect/plasmanetworkmanagement_openconnect_globalprotectui.desktop
  vpn/openvpn/openvpnadvancedwidget.cpp
  vpn/ssh/plasmanetworkmanagement_sshui.desktop
  vpn/ssh/sshwidget.cpp

To: niccolove, jgrulich, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

2020-03-08 Thread Nathaniel Graham 
ngraham added a comment.


  you need to rebase on top of `master` from the remote. This looks to have 
been branched off of the state of master from last November or something.
  
  Try `git pull --rebase origin master` That should give you some merge 
conflicts that you can fix.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27823

To: niccolove, jgrulich, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

2020-03-08 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 77212.
niccolove added a comment.


  rebase

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27823?vs=77203&id=77212

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27823

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/PopupDialog.qml

To: niccolove, jgrulich, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

2020-03-08 Thread Nathaniel Graham 
ngraham added a comment.


  Now it needs a rebase, as there are merge conflicts. :)

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27823

To: niccolove, jgrulich, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

2020-03-08 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 77203.
niccolove added a comment.


  Fixed double declaration

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27823?vs=77004&id=77203

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27823

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/PopupDialog.qml

To: niccolove, jgrulich, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

2020-03-05 Thread Nathaniel Graham 
ngraham requested changes to this revision.
ngraham added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> ConnectionItem.qml:54
>  
> +onContainsMouseChanged: {
> +if (containsMouse) {

`ConnectionItem.qml` already has `onContainsMouseChanged` (at the bottom of the 
file); add the new stuff there.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27823

To: niccolove, jgrulich, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

2020-03-05 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 77004.
niccolove added a comment.


  Nope

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27823?vs=77003&id=77004

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27823

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/PopupDialog.qml

To: niccolove, jgrulich, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

2020-03-05 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 77003.
niccolove added a comment.


  Right margin of button

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27823?vs=77001&id=77003

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27823

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/PopupDialog.qml

To: niccolove, jgrulich, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

2020-03-05 Thread Niccolò Venerandi 
niccolove added a comment.


  Ah, this one.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27823

To: niccolove, jgrulich, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

2020-03-05 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 77001.
niccolove added a comment.


  Remove old highlight

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27823?vs=76911&id=77001

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27823

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/PopupDialog.qml

To: niccolove, jgrulich, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

2020-03-05 Thread Niccolò Venerandi 
niccolove added a comment.


  In D27823#621958 , @ngraham wrote:
  
  > This needs a rebase. Also you probably need to delete the existing 
mouseover highlight effect.
  
  
  Git is telling me this is up to date. Also, what existing mouseover effect?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27823

To: niccolove, jgrulich, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

2020-03-04 Thread Nathaniel Graham 
ngraham added a comment.


  This needs a rebase. Also you probably need to delete the existing mouseover 
highlight effect.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27823

To: niccolove, jgrulich, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27823: Use consistent highlight

2020-03-04 Thread Niccolò Venerandi 
niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
niccolove requested review of this revision.

REVISION SUMMARY
  Use the PlasmaComponents.Highlight feature to be consistent with other lists.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  highlight (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27823

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/PopupDialog.qml

To: niccolove, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart