D27957: [GTK Config] Port all settings to KConfigWatcher

[Mikhail Zolotukhin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R99:702607595599: [GTK Config] Port all settings to 
KConfigWatcher (authored by gikari).

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27957?vs=77320&id=4

REVISION DETAIL
  https://phabricator.kde.org/D27957

AFFECTED FILES
  kded/configvalueprovider.cpp
  kded/gtkconfig.cpp
  kded/gtkconfig.h

To: gikari, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27957: [GTK Config] Port all settings to KConfigWatcher

[Nathaniel Graham]

ngraham added a comment.


  So much less code! Seems to work well for me.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27957

To: gikari, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27957: [GTK Config] Port all settings to KConfigWatcher

[Mikhail Zolotukhin]

gikari updated this revision to Diff 77320.
gikari added a comment.


  - Add forgotten toolbar style

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27957?vs=77317&id=77320

BRANCH
  port-all-to-kconfigwatcher (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27957

AFFECTED FILES
  kded/configvalueprovider.cpp
  kded/gtkconfig.cpp
  kded/gtkconfig.h

To: gikari
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27957: [GTK Config] Port all settings to KConfigWatcher

[Mikhail Zolotukhin]

gikari created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gikari requested review of this revision.

REVISION SUMMARY
  Also remove redundant reparse configuration calls and change
  the ways of reading some settings accordingly.
  
  Depend on: D27956 

TEST PLAN
  1. Apply D27956 
  2. Restart kded5
  3. Apply all the settings possible:
- Fonts
- Icons
- Color Scheme (for dark theme preference setting)
- Icons on buttons
- Icons in menus
- Toolbar style
- Scrollbar behaviour (what happens if you click on scrollbar)
- Animations speed (though I haven't touch it in this diff)
- Decorations button order
  4. Check if all the settings are correctly applied to GTK applications

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  port-all-to-kconfigwatcher (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27957

AFFECTED FILES
  kded/configvalueprovider.cpp
  kded/gtkconfig.cpp
  kded/gtkconfig.h

To: gikari
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart