This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R871:dd180bb4d057: further constrict line parsing of .so files
(authored by sitter).
CHANGED PRIOR TO COMMIT
sitter updated this revision to Diff 79219.
sitter added a comment.
use other string
REPOSITORY
R871 DrKonqi
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28026?vs=77561=79219
BRANCH
parse
REVISION DETAIL
https://phabricator.kde.org/D28026
AFFECTED FILES
sitter added inline comments.
INLINE COMMENTS
> ahmadsamir wrote in backtraceparsergdb.cpp:75
> (Needs rebasing on master).
> I'd move this and define "const bool file" in one place.
Alas the code is garbage enough to read, I prefer the way I've written.
REPOSITORY
R871 DrKonqi
REVISION
ahmadsamir added inline comments.
INLINE COMMENTS
> backtraceparsergdb.cpp:75
> if (!regExp.cap(7).isEmpty()) { //we have file information (stuff
> after from|at)
> bool file = regExp.cap(8) == QLatin1String("at"); //'at' means
> we have a source file (likely)
>
ngraham added a comment.
Looks sane to me.
REPOSITORY
R871 DrKonqi
REVISION DETAIL
https://phabricator.kde.org/D28026
To: sitter, cfeck, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf,
sitter created this revision.
sitter added reviewers: cfeck, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.
REVISION SUMMARY
As seen in https://bugs.kde.org/show_bug.cgi?id=417435 the previous fix
for .so detection
