D28042: [DrKonqi] Port QRegExp to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R871:8d8062fe6bdc: [DrKonqi] Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28042?vs=77744=77995 REVISION

D28042: [DrKonqi] Port QRegExp to QRegularExpression

ahmadsamir added a comment. In D28042#628179 , @sitter wrote: > I wouldn't terribly mind a second pair of eyes. > > Code generally looks good to me though, so if nobody else comments feel free to land in a couple days. OK, thanks.

D28042: [DrKonqi] Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 77744. ahmadsamir added a comment. Fix comment grammar REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28042?vs=77606=77744 BRANCH l-QRE-port (branched from master) REVISION DETAIL

D28042: [DrKonqi] Port QRegExp to QRegularExpression

sitter added a comment. I wouldn't terribly mind a second pair of eyes. Code generally looks good to me though, so if nobody else comments feel free to land in a couple days. INLINE COMMENTS > backtraceparsergdb.cpp:55 > +// "#5 0x7f50e99f776f in QWidget::testAttribute_helper

D28042: [DrKonqi] Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Plasma, davidedmundson, sitter, apol. Herald added a project: Plasma. ahmadsamir requested review of this revision. REVISION SUMMARY Port QRegExp::exactMatch() by using QRegularExpression::anchoredPattern(), unless the pattern is