D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

gikari updated this revision to Diff 77860. gikari edited the summary of this revision. gikari added a comment. - Remove the recolor module. It is D28076 now REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

cblack added a comment. In D28072#629448 , @gikari wrote: > In D28072#629441 , @cblack wrote: > > > In D28072#629439 , @gikari wrote: > > > > > > You

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

gikari added a comment. In D28072#629441 , @cblack wrote: > In D28072#629439 , @gikari wrote: > > > > You simply test the recolouration like how it's been up until now—restart the applications. >

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

cblack added a comment. In D28072#629439 , @gikari wrote: > > You simply test the recolouration like how it's been up until now—restart the applications. > > It doesn't work. This is what I was talking about: > > > It seems like it

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

gikari added a comment. > You simply test the recolouration like how it's been up until now—restart the applications. It doesn't work. This is what I was talking about: > It seems like it applies randomly whenever the GTK app would like to update the colors, but with that module

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

cblack added a comment. In D28072#629425 , @gikari wrote: > - I should add the recoloration module to autoload with GTK applications > > In D28072#629422 , @cblack wrote: > > > The GTK+ module

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

gikari planned changes to this revision. gikari added a comment. - I should add the recoloration module to autoload with GTK applications In D28072#629422 , @cblack wrote: > The GTK+ module shouldn't be in this patch, as it and the functions

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

cblack requested changes to this revision. cblack added a comment. This revision now requires changes to proceed. The GTK+ module shouldn't be in this patch, as it and the functions to write CSS are separate changes. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

gikari updated this revision to Diff 77855. gikari added a comment. - Rebase on master - Add recoloration module REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28072?vs=77723=77855 BRANCH set-colors REVISION DETAIL

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

gikari added inline comments. INLINE COMMENTS > configeditor.cpp:107 > +modifyColorsCssFile(colorsDefinitions); > +// FIXME Find a way to update colors on the fly > +} Also, I would like to move D24275 to kde-gtk-config repo too with autoloading the