D28096: Don't overwrite status

[Konrad Materka]

kmaterka added a comment.


  > Oh you're right. It was not wokring for me on 5.18 so I changed this and it 
worked. But matter of fact it worked on master all allong :)
  
  5.18 is not using this data model, in 5.18 it is used only in configuration 
page. In 5.19 this model is everywhere.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28096

To: davidre, broulik, kmaterka, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28096: Don't overwrite status

[David Redondo]

davidre abandoned this revision.
davidre added a comment.


  In D28096#629508 , @kmaterka wrote:
  
  > > The qml checks the value against the enum but updateItemData inserts the 
string.
  >
  > These are two different roles:
  >  "status" with enum value
  >  "Status" from SNI data
  >
  > The same happens for "category" role.
  >
  > And yeah, I know this is confusing... The best would be to remove all 
unused roles, especially all *Changed. I just copied all from 
`StatusNotifierItemSource`, some of them are deprecated from Plasma 4 times.
  
  
  Oh you're right. It was not wokring for me on 5.18 so I changed this and it 
worked. But matter of fact it worked on master all allong :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28096

To: davidre, broulik, kmaterka, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28096: Don't overwrite status

[Konrad Materka]

kmaterka requested changes to this revision.
kmaterka added a comment.
This revision now requires changes to proceed.


  > The qml checks the value against the enum but updateItemData inserts the 
string.
  
  These are two different roles:
  "status" with enum value
  "Status" from SNI data
  
  The same happens for "category" role.
  
  And yeah, I know this is confusing... The best would be to remove all unused 
roles, especially all *Changed. I just copied all from 
`StatusNotifierItemSource`, some of them are deprecated from Plasma 4 times.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28096

To: davidre, broulik, kmaterka, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28096: Don't overwrite status

[David Redondo]

davidre created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

TEST PLAN
  set an attentionIconByName in kstatusnotifieritemtest

REPOSITORY
  R120 Plasma Workspace

BRANCH
  attention (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28096

AFFECTED FILES
  applets/systemtray/systemtraymodel.cpp

To: davidre
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart