D28185: [applet/systemtray] Us model binding instead of copy

[Konrad Materka]

kmaterka added a comment.


  In D28185#631972 , @apol wrote:
  
  > I'm not convinced this is all that better.
  
  
  Without this `effectiveStatus` never changes. Right now it works by happy 
coincidence - Item is simple destroyed and created in a different, as a side 
effect new value of `effectiveStatus` is used.
  This change tries to fix my mistake introduced in D26992 
. I used QML Loader incorrectly... :(
  Anyway, I changed it a little bin, please check now.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28185

To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28185: [applet/systemtray] Us model binding instead of copy

[Konrad Materka]

kmaterka updated this revision to Diff 78178.
kmaterka added a comment.


  Bind model as well

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28185?vs=78169&id=78178

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28185

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/items/ItemLoader.qml
  applets/systemtray/package/contents/ui/items/PlasmoidItem.qml
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml

To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28185: [applet/systemtray] Us model binding instead of copy

[Aleix Pol Gonzalez]

apol added a comment.


  I'm not convinced this is all that better.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28185

To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28185: [applet/systemtray] Us model binding instead of copy

[Konrad Materka]

kmaterka created this revision.
kmaterka added reviewers: Plasma: Workspaces, Plasma, ngraham, broulik, 
davidedmundson.
kmaterka added a project: Plasma.
kmaterka requested review of this revision.

REVISION SUMMARY
  The `effectiveStatus` parameter was passed as a copy, use proper binding.

TEST PLAN
  No visible impact

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28185

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/items/ItemLoader.qml
  applets/systemtray/package/contents/ui/items/PlasmoidItem.qml
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml

To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart