nicolasfella updated this revision to Diff 82149.
nicolasfella added a comment.
- Also handle ':/' prefix
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28194?vs=78197=82149
BRANCH
qrcicons
REVISION DETAIL
mart added a comment.
ping?
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
REVISION DETAIL
https://phabricator.kde.org/D28194
To: nicolasfella, #plasma, mart
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,
zachus, fbampaloukas, GB_2, ragreen, ZrenBot,
mart added inline comments.
INLINE COMMENTS
> kquickstyleitem.cpp:218
> opt->icon = QIcon(icon.value().toLocalFile());
> +} else if (icon.canConvert() && icon.value().scheme() ==
> QLatin1String("qrc")) {
> +const QString iconUrl = icon.value().mid(3);
should
apol added a comment.
Fixing QIcon would make sense but I'd say getting this in is not the worst
thing either.
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
REVISION DETAIL
https://phabricator.kde.org/D28194
To: nicolasfella, #plasma, mart
Cc: apol, plasma-devel, Orage, LeGast00n,
nicolasfella added a comment.
For more context see https://github.com/nextcloud/desktop/issues/1746
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
REVISION DETAIL
https://phabricator.kde.org/D28194
To: nicolasfella, #plasma, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,
nicolasfella created this revision.
nicolasfella added reviewers: Plasma, mart.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.
REVISION SUMMARY
Allow to use `icon.source: "qrc:/testicon.png"` in buttons.
WIP as there
