D28232: [SpellChecking KCM] Fix the build

This revision was automatically updated to reflect the committed changes. Closed by commit R119:646bd3eecc72: [SpellChecking KCM] Fix the build (authored by ahmadsamir). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28232?vs=78554=78555 REVISION

D28232: [SpellChecking KCM] Fix the build

ahmadsamir updated this revision to Diff 78554. ahmadsamir added a comment. Rebase REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28232?vs=78347=78554 BRANCH l-fix-build (branched from master) REVISION DETAIL https://phabricator.kde.org/D28232

D28232: [SpellChecking KCM] Fix the build

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. > I could rework the patch to make it conditional on 5.14 and keep the iterator-based ctors as-is. May as well merge this and just revert when we're able to use 5.14

D28232: [SpellChecking KCM] Fix the build

bcooksley added a comment. @bport Sorry, but this cannot be left in a broken state like this. Reality is that the `plasma-desktop` repository declares that it depends on a minimum of Qt 5.12 at the moment in CMake, so that is what it needs to build with. Should this be insufficient,

D28232: [SpellChecking KCM] Fix the build

ahmadsamir added a comment. I don't know when the CI will be updated, probably soon based on what I read on IRC #kde-devel, but until then isn't it better to keep the CI working for plasma-desktop? I could rework the patch to make it conditional on 5.14 and keep the iterator-based ctors

D28232: [SpellChecking KCM] Fix the build

bport added a comment. https://community.kde.org/Schedules/Plasma_5#Support_status_by_Release_Series So we need to see if we can update the CI REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28232 To: ahmadsamir, #plasma, bport, meven, crossi, ervin Cc:

D28232: [SpellChecking KCM] Fix the build

ahmadsamir added a comment. In D28232#634281 , @bport wrote: > Next version of plasma will depend on Qt 5.14 AFAIK so it's not a problem to depend on it But the CI still uses 5.12 for the opensuse image, and probably 5.13 for the

D28232: [SpellChecking KCM] Fix the build

bport added a comment. Next version of plasma will depend on Qt 5.14 AFAIK so it's not a problem to depend on it INLINE COMMENTS > CMakeLists.txt:9 > set(QT_MIN_VERSION "5.12.0") > -set(KF5_MIN_VERSION "5.66.0") > Indeed this is needed thanks REPOSITORY R119 Plasma Desktop REVISION

D28232: [SpellChecking KCM] Fix the build

ahmadsamir created this revision. ahmadsamir added reviewers: Plasma, bport, meven, crossi, ervin. Herald added a project: Plasma. ahmadsamir requested review of this revision. REVISION SUMMARY QList/QSet iterator-based ctors are available since Qt 5.14, so we could make the code conditional