D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:5a5e0bc0880b: [kcms/baloo] Refine UI and prepare for more 
indexing options in the future (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28280?vs=78455&id=79153

REVISION DETAIL
  https://phabricator.kde.org/D28280

AFFECTED FILES
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/filteredfoldermodel.h
  kcms/baloo/package/contents/ui/main.qml

To: ngraham, #vdg, #baloo, #plasma, ndavis
Cc: ndavis, bruns, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  In D28280#640239 , @ngraham wrote:
  
  > Currently there are only two choices, yes. However as mentioned before, one 
of the goals of this patch is to future-proof the UI for the addition of more 
options, which is coming soon.
  
  
  Oh right
  
  LGTM

REPOSITORY
  R119 Plasma Desktop

BRANCH
  refine-baloo-kcm-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28280

To: ngraham, #vdg, #baloo, #plasma, ndavis
Cc: ndavis, bruns, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

[Nathaniel Graham]

ngraham added a comment.


  Currently there are only two choices, yes. However as mentioned before, one 
of the goals of this patch is to future-proof the UI for the addition of more 
options, which is coming soon.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28280

To: ngraham, #vdg, #baloo, #plasma
Cc: ndavis, bruns, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

[Noah Davis]

ndavis added a comment.


  Why isn't a checkbox better than a combobox here? Aren't there only 2 
opposite choices here?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28280

To: ngraham, #vdg, #baloo, #plasma
Cc: ndavis, bruns, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

[Nathaniel Graham]

ngraham added a comment.


  Right, so my intention was to make it easy to add a new entry to the combobox 
titled "Metadata-only indexing".

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28280

To: ngraham, #vdg, #baloo, #plasma
Cc: bruns, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

[Stefan Brüns]

bruns added a comment.


  In D28280#634471 , @ngraham wrote:
  
  > Such a complicated setup is probably not going to be typical, I expect. But 
for that we could have an Advanced Settings sheet that allows people to 
customize things with great detail. However we probably don't have to worry too 
much about that for the purpose of this patch since those advanced features 
haven't been made available to the UI yet.
  
  
  
  
  In D28280#634471 , @ngraham wrote:
  
  > Such a complicated setup is probably not going to be typical, I expect. But 
for that we could have an Advanced Settings sheet that allows people to 
customize things with great detail. However we probably don't have to worry too 
much about that for the purpose of this patch since those advanced features 
haven't been made available to the UI yet.
  
  
  We already have 5 of the 7 options, only "Metadata" is new. Though, currently 
only as a global setting.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28280

To: ngraham, #vdg, #baloo, #plasma
Cc: bruns, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

[Nathaniel Graham]

ngraham added a comment.


  Such a complicated setup is probably not going to be typical, I expect. But 
for that we could have an Advanced Settings sheet that allows people to 
customize things with great detail. However we probably don't have to worry too 
much about that for the purpose of this patch since those advanced features 
haven't been made available to the UI yet.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28280

To: ngraham, #vdg, #baloo, #plasma
Cc: bruns, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

[Stefan Brüns]

bruns added a comment.


  In D28280#634405 , @ngraham wrote:
  
  > In D28280#634388 , @bruns wrote:
  >
  > > Try do imagine how the combobox will look like when you add 'Index 
hidden' to the config options.
  >
  >
  > That would be fine. Comboboxes handle many options pretty well.
  
  
  I am more concerned how a user will handle it:
  
  [Disabled ; Filenames+Tags+Comments ; Metadata(Authors,EXIF,etc) ; FullText] 
x [NotHidden ; All] -> 8 options
  
  > In D28280#634390 , @bruns wrote:
  > 
  >> For the "Add folder setting...":
  >>  How about a config dialog **after** the File Dialog?
  >>
  >> This may seem over the top for now, but the next step is to make the 
excludeFilters and mimetype filters configurale from the KCM, and then also per 
folder.
  > 
  > 
  > Oh, that's interesting! Sounds cool. We can probably add that 
post-file-selection dialog for the indexing settings that require it, but since 
not all will, I'm not sure it should be added for all of them.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28280

To: ngraham, #vdg, #baloo, #plasma
Cc: bruns, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

[Nathaniel Graham]

ngraham added a comment.


  In D28280#634388 , @bruns wrote:
  
  > Try do imagine how the combobox will look like when you add 'Index hidden' 
to the config options.
  
  
  That would be fine. Comboboxes handle many options pretty well.
  
  In D28280#634390 , @bruns wrote:
  
  > For the "Add folder setting...":
  >  How about a config dialog **after** the File Dialog?
  >
  > This may seem over the top for now, but the next step is to make the 
excludeFilters and mimetype filters configurale from the KCM, and then also per 
folder.
  
  
  Oh, that's interesting! Sounds cool. We can probably add that 
post-file-selection dialog for the indexing settings that require it, but since 
not all will, I'm not sure it should be added for all of them.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28280

To: ngraham, #vdg, #baloo, #plasma
Cc: bruns, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

[Stefan Brüns]

bruns added a comment.


  For the "Add folder setting...":
  How about a config dialog **after** the File Dialog?
  
  This may seem over the top for now, but the next step is to make the 
excludeFilters and mimetype filters configurabe from the KCM, and then also per 
folder.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28280

To: ngraham, #vdg, #baloo, #plasma
Cc: bruns, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

[Stefan Brüns]

bruns added a comment.


  Try do imagine how the combobox will look like when you add 'Index hidden' to 
the config options.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28280

To: ngraham, #vdg, #baloo, #plasma
Cc: bruns, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

[Nathaniel Graham]

ngraham updated this revision to Diff 78455.
ngraham added a comment.


  use `onActivated:` rather than `onCurrentIndexChanged:` for the combobox

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28280?vs=78454&id=78455

BRANCH
  refine-baloo-kcm-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28280

AFFECTED FILES
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/filteredfoldermodel.h
  kcms/baloo/package/contents/ui/main.qml

To: ngraham, #vdg, #baloo, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Baloo, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch refines the UI added in D28025 
. The basic goal here is to to be able to 
choose
  what type of indexing is done for each path (none, full, or metadata only). I 
wrestled
  for a while with the best way to present this information and also allow it 
to be easily
  changed and eventually settled on a combobox, given that it combines both 
functions into
  one compact control.
  
  The code is made flexible so that once metadata-only indexing is added in the 
future, it
  will be easy to add the appropriate option into the UI.

TEST PLAN
  F8198344: vokoscreenNG-2020-03-25_08-28-23.webm 


REPOSITORY
  R119 Plasma Desktop

BRANCH
  refine-baloo-kcm-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28280

AFFECTED FILES
  kcms/baloo/filteredfoldermodel.cpp
  kcms/baloo/filteredfoldermodel.h
  kcms/baloo/package/contents/ui/main.qml

To: ngraham, #vdg, #baloo, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart