D28408: Bug 416510: Klipper applet closes itself when I click on a history item while the system tray popup is pinned open

[Eugene Popov]

epopov updated this revision to Diff 78827.
epopov added a comment.


  Use `hideOnWindowDeactivate` property instead of `configuration.pin`

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28408?vs=78805=78827

REVISION DETAIL
  https://phabricator.kde.org/D28408

AFFECTED FILES
  applets/clipboard/contents/ui/ClipboardItemDelegate.qml
  applets/systemtray/package/contents/ui/main.qml

To: epopov, ngraham
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28408: Bug 416510: Klipper applet closes itself when I click on a history item while the system tray popup is pinned open

[Eugene Popov]

epopov added a comment.


  In D28408#637476 , @davidedmundson 
wrote:
  
  > As a question, rather than a researched proposal, is it better to check for 
the pin in?
  >
  > systemtray / PlasmoidItem.qml
  >
  >   Connections {
  >   target: applet
  >   onExpandedChanged: {
  >   
  
  
  We should be able to hide the pinned applet by clicking in the system tray 
(at least this can be done now).

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28408

To: epopov, ngraham
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28408: Bug 416510: Klipper applet closes itself when I click on a history item while the system tray popup is pinned open

[David Edmundson]

davidedmundson added a comment.


  As a question, rather than a researched proposal, is it better to check for 
the pin in?
  
  systemtray / PlasmoidItem.qml
  
Connections {
target: applet
onExpandedChanged: {

INLINE COMMENTS

> main.qml:158
> +
> +applet.configuration.pin = Qt.binding(function() { return 
> plasmoid.configuration.pin; });
>  

What happens when this is set with some other applet that doesn't have a pin 
config option?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28408

To: epopov, ngraham
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28408: Bug 416510: Klipper applet closes itself when I click on a history item while the system tray popup is pinned open

[Eugene Popov]

epopov created this revision.
epopov added a reviewer: ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
epopov requested review of this revision.

REVISION SUMMARY
  When I pin a Klipper widget and then click on a history item, the Klipper 
widget closes.
  
  To fix this bug, we need to check if Klipped is pinned, but to be able to do 
this, we also need to "forward" the pinned state from the SystemTray applet to 
the Klipper applet.
  
  BUG 416510

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28408

AFFECTED FILES
  applets/clipboard/contents/ui/ClipboardItemDelegate.qml
  applets/systemtray/package/contents/ui/main.qml

To: epopov, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart