D28428: [screenlocker] listen to notifications from the notification server

2020-03-31 Thread Bhushan Shah
bshah abandoned this revision. bshah added a comment. Closed in favor of the more simpler version. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D28428 To: bshah, davidedmundson Cc: davidedmundson, nicolasfella, plasma-devel, Orage, LeGast00n,

D28428: [screenlocker] listen to notifications from the notification server

2020-03-30 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. We've added a DBus interface to the screensaver host; ksmserver or kwin respectively. That receives the notification and then using a different API over wayland,

D28428: [screenlocker] listen to notifications from the notification server

2020-03-30 Thread Bhushan Shah
bshah updated this revision to Diff 78904. bshah added a comment. - properly wire up the protocol for ksldapp to greeter REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28428?vs=78883=78904 BRANCH bshah/ksld-notifications REVISION DETAIL

D28428: [screenlocker] listen to notifications from the notification server

2020-03-30 Thread Bhushan Shah
bshah updated this revision to Diff 78883. bshah added a comment. - add argument for the notification id in dbus service - add wayland protocol stanza for passing notification data to greeter REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE

D28428: [screenlocker] listen to notifications from the notification server

2020-03-30 Thread Nicolas Fella
nicolasfella added inline comments. INLINE COMMENTS > interface.cpp:213 > > +void Interface::Notify(const QString& app_name, uint replaces_id, const > QString& app_icon, > + const QString& summary, const QString& body, const > QStringList& actions, conding style: &

D28428: [screenlocker] listen to notifications from the notification server

2020-03-30 Thread Bhushan Shah
bshah created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bshah requested review of this revision. REVISION SUMMARY This will allow notification manager to forward the notifications that are meant to be shown on the lockscreen, currently it requires