D28575: Make headings of systray and applet merge

2020-04-16 Thread Niccolò Venerandi 
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:1a6b40cb5e0e: Make headings of systray and applet merge 
(authored by niccolove).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28575?vs=80315=80326

REVISION DETAIL
  https://phabricator.kde.org/D28575

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
  applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml

To: niccolove, #plasma, #vdg, ngraham
Cc: mart, manueljlin, ognarb, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D28575: Make headings of systray and applet merge

2020-04-16 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 80315.
niccolove added a comment.


  third one's a charm

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28575?vs=80314=80315

BRANCH
  systray_merged_topbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28575

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
  applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml

To: niccolove, #plasma, #vdg, ngraham
Cc: mart, manueljlin, ognarb, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D28575: Make headings of systray and applet merge

2020-04-16 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 80314.
niccolove added a comment.


  try 2

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28575?vs=80313=80314

BRANCH
  arcpatch-D28467

REVISION DETAIL
  https://phabricator.kde.org/D28575

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
  applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml

To: niccolove, #plasma, #vdg, ngraham
Cc: mart, manueljlin, ognarb, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D28575: Make headings of systray and applet merge

2020-04-16 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 80313.
niccolove added a comment.


  Only merge if header is actually visible

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28575?vs=79483=80313

BRANCH
  arcpatch-D28467

REVISION DETAIL
  https://phabricator.kde.org/D28575

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
  applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml

To: niccolove, #plasma, #vdg, ngraham
Cc: mart, manueljlin, ognarb, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D28575: Make headings of systray and applet merge

2020-04-13 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  We could still have a sidebar that goes all the way to the top of the pop-up 
and also a grid of items on the main page rather than a flat list. The grid 
items could even animate to their list positions in sidebar form! How exciting.
  
  Anyway, material for another patch, for sure.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  systray_merged_topbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28575

To: niccolove, #plasma, #vdg, ngraham
Cc: mart, manueljlin, ognarb, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D28575: Make headings of systray and applet merge

2020-04-06 Thread Niccolò Venerandi 
niccolove added a comment.


  Should be fixed now

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28575

To: niccolove, #plasma, #vdg
Cc: mart, manueljlin, ognarb, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D28575: Make headings of systray and applet merge

2020-04-06 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 79483.
niccolove added a comment.


  Unnecessary newline

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28575?vs=79482=79483

BRANCH
  systray_merged_topbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28575

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
  applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml

To: niccolove, #plasma, #vdg
Cc: mart, manueljlin, ognarb, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D28575: Make headings of systray and applet merge

2020-04-06 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 79482.
niccolove added a comment.


  There was a wrong spacing

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28575?vs=79477=79482

BRANCH
  systray_merged_topbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28575

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
  applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml

To: niccolove, #plasma, #vdg
Cc: mart, manueljlin, ognarb, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D28575: Make headings of systray and applet merge

2020-04-06 Thread Niccolò Venerandi 
niccolove updated this revision to Diff 79477.
niccolove added a comment.


  Generic fixes

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28575?vs=79344=79477

BRANCH
  systray_merged_topbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28575

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
  applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml

To: niccolove, #plasma, #vdg
Cc: mart, manueljlin, ognarb, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D28575: Make headings of systray and applet merge

2020-04-06 Thread Manuel Jesús de la Fuente 
manueljlin added a comment.


  The last one doesn't have a sidebar and goes back to the list after pressing 
the back button. It looks a bit cleaner but UX wise it's a bit worse too, 
having to click two times to do what currently only requires one. I prefer the 
first and second design but since that one was discussed in the VDG chat I 
didn't want to leave it there

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28575

To: niccolove, #plasma, #vdg
Cc: mart, manueljlin, ognarb, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D28575: Make headings of systray and applet merge

2020-04-06 Thread Marco Martin 
mart added a comment.


  I like the idea of that back button in the sidebar.
  @manueljlin how would the last mockup work? (back button and no sidebar)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28575

To: niccolove, #plasma, #vdg
Cc: mart, manueljlin, ognarb, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D28575: Make headings of systray and applet merge

2020-04-05 Thread Manuel Jesús de la Fuente 
manueljlin added a comment.


  Some mockups: F8216924: image.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28575

To: niccolove, #plasma, #vdg
Cc: manueljlin, ognarb, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28575: Make headings of systray and applet merge

2020-04-05 Thread Carl Schwan 
ognarb added a comment.


  > I'd like to solve that by removing the sidebar and adding a back button, 
but that would be for another patch in the future.
  
  -1 from me to remove the sidebar. I really liked how the sidebar looked in 
the final mockup in T10470  and it is 
consistent with the Kirigami collapsible sidebar drawer  (only the color is 
wrong) F8215991: image.png  F8216863: 
image.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28575

To: niccolove, #plasma, #vdg
Cc: ognarb, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28575: Make headings of systray and applet merge

2020-04-04 Thread Nathaniel Graham 
ngraham added a comment.


  Hmm, here's what I get when I apply this and then D28467 
: F8216515: Screenshot_20200404_213411.png 

  
  Other applets also seem to be affected: F8216520: 
Screenshot_20200404_213522.png 

INLINE COMMENTS

> ExpandedRepresentation.qml:28
> +Item {
> +
> +width: expandedRepresentation.width

Unnecessary newline

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28575

To: niccolove, #plasma, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28575: Make headings of systray and applet merge

2020-04-04 Thread Niccolò Venerandi 
niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  When the applet is a page with a plasmoidHeading as header, merge it with 
systray one.
  Screenshots incoming.
  
  The only big problem is that it looks bad when you open said applet while in 
sidebar view, see:

REPOSITORY
  R120 Plasma Workspace

BRANCH
  systray_merged_topbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28575

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
  applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart