D28627: Adaptive panel opacity

niccolove added a comment. Ping @davidedmundson ? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28627 To: cblack, #plasma, davidedmundson, niccolove, #vdg Cc: apol, ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D28627: Adaptive panel opacity

ngraham added a comment. I still don't notice what you're trying to point out, so I'll take your word for it. :p REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28627 To: cblack, #plasma, davidedmundson, niccolove, #vdg Cc: apol, ngraham, davidedmundson,

D28627: Adaptive panel opacity

niccolove added a comment. In D28627#652806 , @ngraham wrote: > In D28627#652538 , @niccolove wrote: > > > Actually -- this seems to no longer apply panel internal margins? > > > Works for me.

D28627: Adaptive panel opacity

cblack added a comment. @davidedmundson can you take another look at the general direction of the code here? I'd like to know your thoughts on the direction this code is using before I start spending time sanding off the rough parts REPOSITORY R119 Plasma Desktop REVISION DETAIL

D28627: Adaptive panel opacity

ngraham added a comment. In D28627#652538 , @niccolove wrote: > Actually -- this seems to no longer apply panel internal margins? Works for me. In terms of the UI and the scope, I have to agree with @apol though, and maybe go a bit

D28627: Adaptive panel opacity

niccolove added a comment. Actually -- this seems to no longer apply panel internal margins? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28627 To: cblack, #plasma, davidedmundson, niccolove, #vdg Cc: apol, ngraham, davidedmundson, plasma-devel, Orage,

D28627: Adaptive panel opacity

niccolove accepted this revision. niccolove added a comment. Works great! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28627 To: cblack, #plasma, davidedmundson, niccolove, #vdg Cc: apol, ngraham, davidedmundson, plasma-devel, Orage, LeGast00n,

D28627: Adaptive panel opacity

cblack updated this revision to Diff 80035. cblack added a comment. Choreography fixes REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28627?vs=79973=80035 BRANCH arcpatch-D28627 REVISION DETAIL https://phabricator.kde.org/D28627 AFFECTED

D28627: Adaptive panel opacity

niccolove added a comment. I feel like it makes sense for the user to want to use a opaque panel rather than a transparent one. Also, that relies on themes actually turning on the effect, while users could already benefit from it even on current themes if the setting was exposed. Also, that

D28627: Adaptive panel opacity

apol added a comment. In D28627#646898 , @ngraham wrote: > +1 for making this a user-controllable setting, but how does it interact with plasma themes where there isn't any transparency? Can we only show this UI for plasma themes with

D28627: Adaptive panel opacity

ngraham added a comment. +1 for making this a user-controllable setting, but how does it interact with plasma themes where there isn't any transparency? Can we only show this UI for plasma themes with transparency? REPOSITORY R119 Plasma Desktop REVISION DETAIL